Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add useInsertionEffect to the dispatcher #84

Open
advl opened this issue Mar 19, 2023 · 0 comments
Open

Add useInsertionEffect to the dispatcher #84

advl opened this issue Mar 19, 2023 · 0 comments

Comments

@advl
Copy link

advl commented Mar 19, 2023

Hello,

The dispatcher is missing useInsertionEffect introduced in React 18. It should be mapped to a noop function as useLayoutEffect.

It would be just a one-line addition under this https://github.com/FormidableLabs/react-ssr-prepass/blob/master/src/internals/dispatcher.js#L356 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@advl