-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with dom-iterator
and webpack
#5
Comments
for now, I worked around this by using |
Can you create some kind of reproduction? I'm not entirely sure why this is happening and I'm using this in several webpack projects myself |
Hey, reiterating on this. I'm not sure what's going on with your webpack config, but I assume it's not using the bundled version since it's not webpack 2 and is having trouble with that dependency. I suggedt you alias react-live to the umd bundle in that case :) |
In my case, I'm adding |
@webOS101 Worst case, I already have selection-range vendored, I can just rewrite the part that depends on dom-iterator |
Hi! I'm also having trouble using react-live with Gatsby. Did anyone come up with a work around for this problem? |
I solved this problem by creating a
Hopefully that works, I extracted it from a much bigger file. |
I still have to look into this and haven't gotten to it yet. This doesn't occur with the bundled ES version of the package, so you can try that: https://github.com/FormidableLabs/react-live/blob/master/package.json#L7 Or the minified one (uargh) I'll take a look at the dom-iterator package asap (except if someone else is interested of course) |
Hi all 😄
I've encountered this same issue when running In case it's at all helpful, my Gatsby project is available at bvaughn/react/tree/gatsby/www. |
This works around a react-live issue (reported as FormidableLabs/react-live/issues/5) that was blocking the 'yarn buid' task for Gatsby, which in turn blocks the Netlify setup.
This will be fixed by #89 which will use react-simple-code-editor instead, so I'll tentatively close this issue |
The
dom-iterator
dependency causes problems in my webpack project when I import fromreact-live
. Webpack tries to package thexor
require()
which is in acatch
block in that package. The error looks like this:Any suggestions on how to get around this problem? Note this also happens for the
props
module required the same way in that module.Oddly, I don't have this problem with development builds, only production builds. Possibly something in my webpack config?
The text was updated successfully, but these errors were encountered: