Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display negative numbers consistently #289

Open
tomusdrw opened this issue Jan 13, 2025 · 1 comment · May be fixed by #307
Open

Display negative numbers consistently #289

tomusdrw opened this issue Jan 13, 2025 · 1 comment · May be fixed by #307
Assignees
@wkwiatek
Labels
enhancement New feature or request prio-high

Comments

@tomusdrw
Copy link
Contributor

The negative numbers in immediates are not displayed consistently.
image

Compare:
ADD_IMM_32 and JUMP - the first displays a large number (which in reality is -1), while the latter displays -13.

We should consistently display immediates as negative values.
@tomusdrw tomusdrw added enhancement New feature or request prio-high labels Jan 13, 2025
@tomusdrw
Copy link
Contributor Author

CC @mateuszsikora can this be all negative?

@wkwiatek wkwiatek self-assigned this Jan 21, 2025
@wkwiatek wkwiatek linked a pull request Jan 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkwiatek wkwiatek

Labels
enhancement New feature or request prio-high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show all instruction arguments as signed numbers consistently FluffyLabs/pvm-debugger
2 participants
@tomusdrw @wkwiatek