Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inventory/Topic should be typed and returns typed object, not dict #192

Open
isra17 opened this issue Jun 1, 2022 · 0 comments
Open

Inventory/Topic should be typed and returns typed object, not dict #192

isra17 opened this issue Jun 1, 2022 · 0 comments
Labels
API Involve documented API breaking change Issue that involve breaking change to public API

Comments

@isra17
Copy link
Member

isra17 commented Jun 1, 2022

Right now TopicMessage have args as dict. This make it confusing to the implementer that is used to deal with dataclasses everywhere else. Also, this do not expose any typing information anywhere else that can be used to type check topology.
@isra17 isra17 added breaking change Issue that involve breaking change to public API API Involve documented API labels Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Involve documented API breaking change Issue that involve breaking change to public API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@isra17