Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Cancellation token for async methods #87

Open
HHHackGit opened this issue Nov 23, 2023 · 2 comments
Open

Question: Cancellation token for async methods #87

HHHackGit opened this issue Nov 23, 2023 · 2 comments
Assignees

Comments

@HHHackGit
Copy link

Hi! FlagsmithClient contains many asynchronous methods without CancellationToken support. Are there any plans to add CancellationToken to the methods? Thanks for answer!

@dabeeeenster
Copy link
Contributor

One for @novakzaballa

@novakzaballa
Copy link
Contributor

Hi @HHHackGit , thank you for your feedback!
In general, we try to maintain a seamless behavior among our different SDKs. Some of the async tasks in the .Net client already incorporate embedded logic to handle timeouts, errors, and calls to the dispose() method by using CancellationToken. So far it seems that the users' needs are covered by this internal logic. Please let us know if you would like to be able to provide your own cancellation token for specific methods, justifying that with use cases or scenarios. so we can see if that can be supported by the existing logic or we should implement it for .Net and other clients. It would be great if you could add those scenarios in the description of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants