Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify testing structure/tools [JSTEP-10] #268

Closed
JooHyukKim opened this issue Jan 11, 2025 · 7 comments
Closed

Unify testing structure/tools [JSTEP-10] #268

JooHyukKim opened this issue Jan 11, 2025 · 7 comments
Labels

Comments

@JooHyukKim
Copy link
Member

JooHyukKim commented Jan 11, 2025

This issue serves as an umbrella issue for resolving [JSTEP-10: Unifying testing structure/tools]

TODO

  • Add JUnit 5 dep + failing test utils
  • Migrate modules to JUnit 5
  • Migrate failing tests to /tofix and remove existing /failing funciontality
  • Remove JUnit 4
cowtowncoder added a commit that referenced this issue Jan 17, 2025
Start work on #268: junit5 conversion; first demote junit4 dependency
cowtowncoder added a commit that referenced this issue Jan 18, 2025
@cowtowncoder
Copy link
Member

So far converted:

  • afterburner
  • android-record
  • guice
  • guice7

Biggest remaining work is blackbird

@cowtowncoder
Copy link
Member

And with @JooHyukKim's work, all the rest -- Blackbird, jakarta-xmlbind, jaxb, paranamer, OSGi -- also converted.

What remains is converting "failing" tests to "tofix" ones, and then promoting JUnit5 dependencies from sub-modules' pom.xmls back to parent pom.xml.

@cowtowncoder
Copy link
Member

Whops. Still need to "mrbean".

@cowtowncoder
Copy link
Member

Status:

  • All modules converted to use JUnit5
  • JUnit5 dependency at main level (no per-module deps)

so what remains is just

  • Convert "failing" tests to "tofix" ones.

@JooHyukKim
Copy link
Member Author

Filed last remaining pieces in two PR's "in order"! 👍🏼

@cowtowncoder
Copy link
Member

Thanks! Will get these merged today.

@cowtowncoder cowtowncoder changed the title JSTEP-10: Unifying testing structure/tools Unify testing structure/tools [JSTEP-10] Jan 19, 2025
cowtowncoder added a commit that referenced this issue Jan 19, 2025
@cowtowncoder
Copy link
Member

Merged, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants