Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not fail on trying to serialize java.time.DateTimeException #4718

Closed
cowtowncoder opened this issue Sep 28, 2024 · 1 comment
Closed

Should not fail on trying to serialize java.time.DateTimeException #4718

cowtowncoder opened this issue Sep 28, 2024 · 1 comment
Labels
2.17 Issues planned at earliest for 2.17

Comments

@cowtowncoder
Copy link
Member

Describe your Issue

(note: offshoot of FasterXML/jackson-modules-java8#319)

Looks like checks to support detection of "missing Java 8 date/time ser/deser support" gives false alert on DateTimeException. And since it should be serializable just fine (as opposed to value types where POJO handling would be wrong), we should relax check in BeanUtil to not block it.

But instead of allow-listing one name, I think we should just skip all Throwable types.
@cowtowncoder cowtowncoder added to-evaluate Issue that has been received but not yet evaluated 2.17 Issues planned at earliest for 2.17 and removed to-evaluate Issue that has been received but not yet evaluated labels Sep 28, 2024
@cowtowncoder cowtowncoder mentioned this issue Sep 28, 2024
Closed
@cowtowncoder cowtowncoder changed the title Should not fail on trying to serialize DateTimeException Should not fail on trying to serialize java.time.DateTimeException Sep 29, 2024
cowtowncoder added a commit that referenced this issue Sep 29, 2024
@cowtowncoder
Fix #4718: don't fail on serialization of DateTimeException
2dff2b2
@cowtowncoder
Copy link
Member Author

Backported in 2.17(.3).

cowtowncoder added a commit that referenced this issue Sep 29, 2024
@cowtowncoder
(bacport) Fix #4718: don't fail on serialization of DateTimeException (…
b6da0d5 
…#4721)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.17 Issues planned at earliest for 2.17
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cowtowncoder