AnnotatedCreatorCollector should avoid processing synthetic static (factory) methods

[carterkozak]

This implementation matches the AnnotatedMethodCollector which
also avoids synthetic methods. In the debugger I found most
iterations through _findPotentialFactories were checking synthetic
methods from lambdas rather than human-declared methods.

[cowtowncoder]

Quick question: is there specific bug fixed (if so, would be great to have a unit test), or is it optimization?
Both are fine, but if latter, I'd prefer rebase against 2.12 just to minimize any risk (seems like there's non-zero risk here).

[carterkozak]

Quick question: is there specific bug fixed (if so, would be great to have a unit test), or is it optimization?

I haven't encountered a specific bug, but I'm not confident that this couldn't result in a bug (and it would be mind-bending to debug!). If the static method requires a specific name or annotation to be used as a factory when no other creators exist, it should be fine to target 2.12.
Happy to target into 2.12 for now, and we can backport if there's a failure it resolves.

[cowtowncoder]

@carterkozak yeah let's do 2.12 then -- I am ok with minor risk for new minor versions.

[carterkozak]

Sounds good, I've updated the target.