Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to change default RecyclerPool for 2.17.0 ? #1293

Closed
artemus717 opened this issue Jun 3, 2024 · 5 comments
Closed

How to change default RecyclerPool for 2.17.0 ? #1293

artemus717 opened this issue Jun 3, 2024 · 5 comments

Comments

@artemus717
Copy link

Maybe there are some memory leak issue with 2.17.0. We are running OpenSearch 2.14.0 which use jackson-core 2.17.0.
I want to try change default RecyclerPool to see if jvm heap will back to normal.

Thanks

@plokhotnyuk
Copy link

plokhotnyuk commented Jun 3, 2024

You can add .recyclerPool(JsonRecyclerPools.threadLocalPool()) when building JsonFactory like here, but a better option is upgrading jackson-core to 2.17.1 or above.

@pjfanning
Copy link
Member

relates to #1256

@artemus717
Copy link
Author

You can add .recyclerPool(JsonRecyclerPools.threadLocalPool()) when building JsonFactory like here, but a better option is upgrading jackson-core to 2.17.1 or above.

did 2.17.1 not use lock free pool as default ?

@pjfanning
Copy link
Member

You can add .recyclerPool(JsonRecyclerPools.threadLocalPool()) when building JsonFactory like here, but a better option is upgrading jackson-core to 2.17.1 or above.

did 2.17.1 not use lock free pool as default ?

please read #1256

@artemus717
Copy link
Author

OK I changed to 2.17.1 in my OpenSearch cluster to see if it's OK.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants