-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LICENSE
misssing from 2.15.1 jar
#1032
Comments
@pjfanning There is root-level Either way, yes, we do want LICENSE included and its dropping was not intentional |
Looks like 2.15.0 jar does have |
I tried a few maven plugins but still struggling to get the LICENSE included. Is it ok if I just copy it to src/resources/META-INF again? This change is still going to be painful because FastDoubleParser has clashing files that we need to keep (but rename). I already had to rename the NOTICE as src/resources/META-INF/jackson-core-NOTICE and rename it as part of the maven shade task execution. The plan would to do something similar for the LICENSE file. |
@pjfanning yes, if nothing else works (easily enough) ok to duplicate. |
Was removed by c04e924#diff-8eac27e2b7403d363ecdb0a19ea08fafe1aa78484e74fb74664d50f202bc2e94
I think it would be better to have the LICENSE in the jar. The one that was removed by the commit was probably fine.
The text was updated successfully, but these errors were encountered: