Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Network ... AP Collapse function traces back + related issues. #27

Open
RobMackie opened this issue Jun 17, 2022 · 1 comment

Comments

@RobMackie
Copy link

routes/network.js::hotspotState fails because "network" object is undefined.
var network = require('../updater').networkManager;

fails to create a network object.

Examination of /fabmo-updater/updater.js shows that every references to networkManager has been commented out. I believe it was commented out when Ted brought the updater back into service. I think the network management functions of the updater have never been coded to work on the pi, only on the edison image.

Need to decide if it's something we fix or eliminate. the line "var network = require('../updater').networkManager;" appears in the routes/network.js file 11 times which means that object is needed at least in that many places.

Also, it seems bizarre to create the object in each function rather than at the module level.

@tedh-shopbot tedh-shopbot changed the title AP Collapse function traces back + related issues. Refactor Network ... AP Collapse function traces back + related issues. Aug 23, 2023
@tedh-shopbot
Copy link
Contributor

Move on to removing network functionality form updater (except perhaps for reporting) -- and continue refactoring.
Having committed to the Pi, networking is primarily handled in the image setup rather than by FabMo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants