Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect singletons->string guarding #1137

Closed
ptheywood opened this issue Oct 27, 2023 · 0 comments · Fixed by #1139
Closed

Incorrect singletons->string guarding #1137

ptheywood opened this issue Oct 27, 2023 · 0 comments · Fixed by #1139
Assignees
@Robadob
Labels
bug

Comments

@ptheywood
Copy link
Member

#1116 introduced bug(s) related to the guarding of singletons->strings in CUDASimulation.cu.

strings is only defined as a member for builds with FLAMEGPU_SEATBELTS defined to a truthy value (i.e. not defined to 0).

However, it is used in places where those guards are not present as of 7a7944d.

This needs fixing (and we should add a FLAMEGPU_SEATBELTS=OFF build to CI to prevent this from occurring in the future, #1136).

Discovered by @daniele-baccega in #1135
@ptheywood ptheywood added the bug label Oct 27, 2023
@Robadob Robadob self-assigned this Oct 27, 2023
@ptheywood ptheywood mentioned this issue Oct 27, 2023
Merged
3 tasks
Robadob added a commit that referenced this issue Oct 27, 2023
@Robadob
FLAMEGPU_SEATBELTS=OFF did not build
bea73ac 
This bug was introduced by #1116

Closes #1137
@Robadob Robadob mentioned this issue Oct 27, 2023
Merged
Robadob added a commit that referenced this issue Oct 28, 2023
@Robadob
FLAMEGPU_SEATBELTS=OFF did not build
c4ab1af 
This bug was introduced by #1116

Closes #1137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Robadob Robadob

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FLAMEGPU_SEATBELTS=OFF did not build FLAMEGPU/FLAMEGPU2
2 participants
@ptheywood @Robadob