New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme.md: Request 18 #7

Open

SBlechmann opened this issue Jul 25, 2019 · 1 comment

SBlechmann commented Jul 25, 2019

The curl request in "request 18" should be a POST not a PUT.

Member

jason-fox commented Jul 25, 2019 •

edited

Loading

This is a flaw/reversion in the API interface of Keyrock. Actually it should be a PUT if the API interface follows HTTP Standards.

The action is idempotent, and therefore should be PUT not POST.

A PR was raised for this and accepted:

Idempotent Update endpoints should use PUT ging/fiware-idm#34

This is change appears to have been missed or lost at some point, so the issue needs to be raised in the Keyrock repository.

jason-fox mentioned this issue

Add PUT endpoint for idempotent action ging/fiware-idm#104

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment