Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding parameters for germline and somatic genomicSourceClass #48

Open
fatemaker254 opened this issue Apr 3, 2023 · 3 comments
Open
Assignees
Labels

Comments

@fatemaker254
Copy link
Contributor

Issue

Adding parameters for germline and somatic genomicSourceClass

Context

Under Subject Genotype Operations the Patient NB6TK328's genotype under finding_subject_haplotype showing same results for both somatic and germline genomicSourceClass parameter.

Solution

Different output should be displayed after selection of either genomic or somatic genomicSourceClass.

@fatemaker254
Copy link
Contributor Author

Hi @Rohan-cod please assign me to this issue.

@rhdolin
Copy link
Collaborator

rhdolin commented Apr 12, 2023

Let's defer this one for now - currently, none of the haplotype data in the reference implementation has genomicSourceClass populated, so tightening this logic might be confusing (e.g. searching specifically for 'germline' will return zero results).

@fatemaker254
Copy link
Contributor Author

Yeah got your point @rhdolin . While resolving this doubt I also saw that the actual.json was not getting created properly for specific genomicSourceClass since the searching was not giving any specific output based on that class, I think that was because of this reason only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants