Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding edge_tags and vertex_tags to gmshio #3482

Open
bayswiss opened this issue Oct 25, 2024 · 1 comment
Open

Adding edge_tags and vertex_tags to gmshio #3482

bayswiss opened this issue Oct 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@bayswiss
Copy link

Describe new/missing feature

gmshio functions model_to_mesh and read_from_mesh return (only) the triplet (mesh, cell_tags, facet_tags), it would be very useful if it returned also edge_tags and vertex_tags, like in the following:

https://github.com/ComputationalPhysiology/cardiac-geometriesx/blob/f7d304600972992299ef6d3938adeebd4c4e2af2/src/cardiac_geometries/utils.py#L47

Suggested user interface

No response

@bayswiss bayswiss added the enhancement New feature or request label Oct 25, 2024
@jhale
Copy link
Member

jhale commented Oct 25, 2024

Seems like a good idea - in terms of implementation we should consider using a namedtuple for the tags as the number of return arguments is getting unwieldy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants