Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vectorized versions of push_forward and pull_back to the Python interface of CoordinateElement #3408

Open
jorgensd opened this issue Sep 16, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jorgensd
Copy link
Member

Describe new/missing feature

Is needed for performance and should probably happen in the nanobind layer.

We still need to decide if:

  1. Should we pull back all input points for an array of cells (cell geometries)? Does this really make sense?
    • If not, should we send in a list of numpy arrays, where the i-th entry of the list is a 2D array for pulling back to the i-th cell geometry?
  2. Should we push forward all input points for an array of cells (this makes more sense (for instance if pushing quadrature points forward).

Above, one has to extract the cell-geometry in Python, and then pass it to the C++ interface, would it make more sense to pass in cell-indices, and let the nanobind layer pack the geometry data? Or does this remove some generality, where one would like to perturb mesh coordinates without moving the mesh itself?

Suggested user interface

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant