Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about cadets dataset results #19

Open
m-shayan73 opened this issue Oct 12, 2024 · 0 comments
Open

Question about cadets dataset results #19

m-shayan73 opened this issue Oct 12, 2024 · 0 comments

Comments

@m-shayan73
Copy link

m-shayan73 commented Oct 12, 2024

Hello, I am seeing a difference in results I get from the provided "distance_save_cadets.pkl" in the repo and the one I create from the provided code.

Results I get when I run eval.py with the provided "distance_save_cadets.pkl" file:
Screenshot from 2024-10-12 19-02-13

Results I get if i create a new distance_save_cadets.pkl" file from the provided code:
Screenshot from 2024-10-12 18-58-08

There is a notable increase in the false positives (and decrease in true negatives hence a dip in precision and f1 score). For both, I am using the same/default condition to find best_idx (if dataset == 'cadets' and rec[i] < 0.9976) and n_neighbors (200).

Am I missing something? Would appreciate any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant