Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bin handling for discrete parameter types #20

Open
benkrikler opened this issue May 16, 2019 · 1 comment
Open

Improve bin handling for discrete parameter types #20

benkrikler opened this issue May 16, 2019 · 1 comment
Labels
Feature Request good first issue Good for newcomers originally gitlab For items that were originally created on gitlab and imported over Stage: BinnedDataFrame

Comments

@benkrikler
Copy link
Member

Imported from gitlab issue 20

Currently there is no way to pre-inform carpenter what values to expect for discrete variables, eg. categoricals, natural numbers etc. This results in bins that would be expected, not being present in the resulting dataframe, especially for natural number variables. The config file specification should be expanded to handle these situations better.

First raised within CMS-CHIP: https://gitlab.cern.ch/cms-chip/chip/issues/7

@benkrikler benkrikler added Feature Request originally gitlab For items that were originally created on gitlab and imported over Stage: BinnedDataFrame labels May 16, 2019
@benkrikler benkrikler added the good first issue Good for newcomers label May 24, 2019
@benkrikler
Copy link
Member Author

So two new options seem sensible to me:

  1. ranges for ordered but discrete parameters (e.g. number of hits in an event, but clipped to between 0 and 20)
  2. a list of expected values (e.g. category names)

For 1:

For 2:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request good first issue Good for newcomers originally gitlab For items that were originally created on gitlab and imported over Stage: BinnedDataFrame
Projects
None yet
Development

No branches or pull requests

1 participant