Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local development is a bit painful after switching to a built JS bundle on dev #181

Open
marcaaron opened this issue Sep 21, 2022 · 4 comments

Comments

@marcaaron
Copy link
Contributor

Problem:

On dev we are pointing to dist/web.development.js which is a bit more difficult to test code changes.

My current workaround is:

Run npm run build in /react-native-onyx

Copy web.developent.js to local project/node_modules/react-native-onyx/dist

Potential Solutions:

  • Stop using that build and just use the local files in node_modules directly

OR

  • Use webpack to watch changes and build the dist + link local node_modules to local react-native-onyx

I would prefer the former as having the minified builds in sources makes debugging things harder for no clear benefit.

@87prashant
Copy link

Hi, is the development still active? One more thing is this repo earlier under @lucasbento account, just curious.

@marcaaron
Copy link
Contributor Author

Could you please rephrase that question? I'm not sure what you're asking, thanks!

@87prashant
Copy link

87prashant commented Dec 20, 2022

I was asking is this react-native-onyx project is built by Expensify from zero or earlier it was under some other account on github?
Actually, I was asking about this project from chatGPT and it gave this info that it is created by someone else(probably wrong😝). Btw thanks for replying

@marcaaron
Copy link
Contributor Author

hah well the AI is wrong. This is entirely built by the team at Expensify from the ground up and with help from open source contributors. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants