Deploy Checklist: New Expensify 2023-08-30

[OSBotify]

Release Version: 1.3.59-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Handle Plaid events like secure does #20747
• allow Request money 'Description' to accept multiline #21664
• Fix Tooltip content only have comma in content when hovering group chat with non-register users #23807
• 23298 - Desktop - Unable to move click>dragging the header in desktop app #24098
• migrate ReportScreen.js #24111
• Fix: Quickly press different menu items opens them one by one #24173
• fix: 23886 Composer out focus when the thread has many messages #24369
• Fix/22929 forwardref console error #24405
• Comment linking redirects #24411
• Display status emojis in the LHN (including the user's own status) #24414
• [NO QA] Improve app launcher icon padding #24440
• Fix emoji picker hide itself when there is an archived chat in the navigation stack #24479
• chore: update extensions allowed by ios app #24493
• fix: move emoji suggestions to portals #24541
• The popup menu overlaps the + icon on room #24542
• Rewrite CompanyStep.js to functional component #24616
• fix: show existing reports while loading #25159
• Migrate BaseOptionsList.js to functional component #25401
• Add edit request button to the report action context menu #25429
• Migrate OnfidoPrivacy.js to functional component #25458
• Add GTM to helpDot #25519
• Fix some storybook errors #25520
• fix: 23958 reload attachment preview and close, app displays random chat for few seconds #25521
• Fix: 24375 Navigation arrows are not shown on PDF until navigated to an image #25529
• Performance: Onyx new storage wrapper (idk-keyval) #25565
• [23543] Multi words zones now work while searching for timezones. #25569
• Migrate ImageView to a functional component #25579
• Fix scroll on native when going back to the login page  #25590
• fix: allow vertical scroll on multiline horizontal scrollable code block for Android Chrome #25605
• Return early for hidden notification preference #25618
• fix: use stripped amount for new selection #25624
• fix - Translate IOU contents to the correct langauage #25629
• Fix Issue 24522: User should not access add debit card with no permissions #25652
• fix IllustratedHeaderPageLayout.js padding bottom #25654
• Fix: Big number pad button size is not justified on small screens #25656
• fix: last backtick should be in inline codeblock when sending a text wrapped with two backticks #25659
• Mention list doesnt automatically popup when typing @ #25660
• rewrite BaseModal to a functional component #25672
• Fix different grayness levels on parent and child messages. #25675
• Imitate web event in native image renderer #25700
• Fixing the freeze on ios when we choose multiple emojis quickly #25708
• Calculating the devicePixelRatio for the pdf to display with less pixels than the limit of the platform #25721
• Simplify logic for getTransactionsWithReceipts #25731
• Fix: Android - Error attempting to download an attachment #25742
• [24231] Fixed completed task in English instead of Spanish. #25743
• [No QA][TS migration] Migrate 'getPlatform' constants dependency to TypeScript #25745
• [NO QA] [TS migration] Migrate 'SCREENS.js' constant to TypeScript #25747
• [No QA] [TS migration] Migrate roundToNearestMultipleOfFour function to TypeScript #25749
• Added Condition to check drag & drop works only on scan page #25750
• Added Fill props to both component #25751
• [No QA] migrate config to ts #25753
• [No QA] [TS migration] Migrate 'writingDirection.js' style to TypeScript #25755
• Add developmentDebug to debuggableVariants #25757
• Performance: chat input #25758
• fix: Inconsistent error messages shown on wrong magic code #25762
• [No QA][TS migration] Migrate 'CONST.js' constant to TypeScript #25764
• [No QA] [TS migration] Migrate sizing.js to TypeScript #25766
• Cleanup tab selector translations #25782
• fix: use correct title key for waypoint editor #25808
• fix: handle forward-delete properly in the amount text input #25815
• Performance: optimize getDefaultAvatar calculation #25816
• [No QA] [TS migration] Migrate 'wordBreak' style to TypeScript #25825
• [No QA] [TS migration] Migrate 'whiteSpace' style to TypeScript #25826
• [No QA] [TS migration] Migrate 'visibility' style to TypeScript #25828
• [No QA] [TS migration] Migrate 'flex.js' style to TypeScript #25831
• [No QA] [TS migration] Migrate 'userSelect' style to TypeScript #25832
• [No QA] [TS migration] Migrate 'pointerEventsAuto' style to TypeScript #25840
• [No QA] [TS migration] Migrate 'overflowXHidden' style to TypeScript #25842
• [No QA] [TS Migration] Migrate overflowAuto to TypeScript #25844
• [CP Staging] Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #25847
• [No QA] [TS migration] Migrate 'optionAlternateTextPlatformStyles' style to Typescript #25848
• [No QA] [TS migration] Migrate 'italic' style to TypeScript #25849
• [No QA] [TS migration] Migrate 'getPopOverVerticalOffset' style to TypeScript #25858
• [NoQA] Look for patch files changes in set up node action #25861
• [No QA][TS migration] Update Typescript guidelines: 'satisfies' keyword + module augmentation #25862
• Fixing the race condition on history.go due to buggy queue async callbacks #25866
• fix: suppress highlight on iOS for workspace bills #25873
• add margin bottom below show more #25876
• show disabled cursor on checkbox and "Select All" if they are unclickable #25882
• Fixed composer not catching paste events when unfocused #25900
• Fix PDF zooming to top left on double tap #25907
• Fix: Inconsistent auto capitalize between legal name page and display name page. #25911
• Fix multiple metro versions #25912
• Update money request related pages PropTypes #25914
• [No QA] [TS Migration] convert ThemeStylesContext.js style to TypeScript #25915
• [No QA] [TS migration] Migrate 'optionRowStyles' style to TypeScript #25916
• [No QA] [TS migration] Migrate 'codeStyles' style to TypeScript #25917
• [No QA] [TS migration] Migrate 'fontFamily' style to TypeScript #25918
• [No QA] [TS migration] Migrate 'editedLabelStyles' style to TypeScript #25919
• [CP Staging] Fix selection list regressions: page animation, scroll indicator, first member highlight, bold text #25921
• [No QA] [TS migration] Migrate 'getNavigationModalCardStyles' style to TypeScript #25923
• Default to empty merchant for receipt requests #25924
• [No QA] [TS migration] Migrate 'variables.js' style to TypeScript #25943
• [No QA] [TS migration] Migrate 'overflow.js' style to TypeScript #25944
• Create Insights Help page #25954
• [CP Staging] fix(selection-list): scroll to top, cmd enter, tab key #25955
• Make sure composer doesn't render in loading state (null) #25957
• Update en.js #25958
• Fix: skeleton ui does not show when contact are loading #25959
• [NoQA] Revert "Fixing the race condition on history.go due to buggy queue async callbacks" #25963
• Load generic receipt thumbnail for other file formats #25969
• Show recent waypoints when selecting address for distance request #25974
• Don't focus when ref composer is unmounted #25981
• Add option to delete stop #25984
• match Dev logo color to Staging and fix clipping of logo in smaller screens #25986
• [NO QA] fix getPlatform method by deleting index.js file #26023
• Fix Back button is overlapping with notification bar on mobile devices #26035
• remove screenwrapper causing extra padding in large devices #26042
• Fix BaseModal #26045
• [CP Staging] Fix/24389 - Request a money - Clicking on the avatar open a wrong profile  #26055
• [TS migration] Migrate 'positioning.js' style to TypeScript #26056
• Fix: use focusWithDelay #26057
• [No QA] [TS migration] Add naming conventions for prop types #26081
• Remove MakeCancellablePromise.js #26095
• [No QA][TS migration] Migrate CardUtils.js lib to TypeScript #26100
• [TS migration] Migrate 'getModalStyles' style to TypeScript #26105
• Allow international address search #26122
• [No QA] fix: lint error for recent waypoints #26124
• fix: keep consistency with backend email validation #26145
• remove extra padding for paypal button #26153
• [No QA] [TS migration] Migrate 'getPlaidOAuthReceivedRedirectURI' lib to TypeScript #26163
• [No QA] [TS migration] Migrate 'getClickedTargetLocation' lib to TypeScript #26168
• Don't show the Download App Banner until Past Sign in  #26182
• [No QA] [TS migration] Migrate 'ComponentUtils' lib to TypeScript #26199
• fix crash when using the on-screen numpad caused by improperly set prop #26267
• Fix FAB not appearing #26293
• [NO QA] Provide default launcher asset for production builds #26296
• [CP Staging] Update Onyx to fix set memory only keys crash #26305
• Set optimistic report status correctly in payMoneyRequest #26352

Internal QA:

• [CP Staging] Change isSettled to check for status only #26292 - @youssef-lr
• [CP Stag] Remove unneeded SaaStr & SBE account consts #25827 - @Beamanator
• Implement report approvals #24639 - @youssef-lr
• [New Feature] - Teachers Unite sign-up flows #23063 - @youssef-lr

Deploy Blockers:

• [$1000] Web - Two users requesting money to each other at the same time at the same time causes console error and the second user lefts untested in the request room #26273
• [HOLD for payment 2023-09-12] [$500] FAB - Symbols are allowed in legal name #26275
• Incositancy: Description does not accept multiline in the IOU report page #26277
• Request Money - Text written with line breaks is connected together when Editing Description #26279
• [HOLD for payment 2023-11-21][$1000] FAB - After a refresh, clicking back button on the 'I am a teacher' page does not take you back to the previous page #26282
• [$500] IOU Distance - Save button in waypoint editor is not responsive #26286
• IOU - Unable to empty the merchant field to set it to default value 'Request' #26287
• [$500] [HOLD for payment 2023-09-07] [HOLD for payment 2023-09-07] 'FAB' popover menu is not opened when user Sign-up #26288
• [HOLD for payment 2023-09-07] [HOLD for payment 2023-09-07] Chat - Global create menu not displayed after tapping no thanks on banner #26289
• Save the world - Tapping "I am a teacher" user is prompted to update the email address #26291
• Dev - Missing LHN #26311
• [HOLD for payment 2023-09-18] [$500] Deeplinks - Not found page for concierge chat link after sign in #26314
• Web - App focus on compose box even when edit message is present #26319
• [HOLD for payment 2023-09-07] [HOLD for payment 2023-09-07] IOU - Can tap multi times on "Pay elsewhere" button when offline #26322
• IOU Distance - Recent address list flickers when clearing the address field #26324
• [HOLD for payment 2023-09-21] Bank account - Temporarily disabled message not displayed after 21 attempts #26354
• https://github.com/Expensify/Expensify/issues/312346

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.59-0 🚀

[mvtglobally]

@luacmartins We will start regression in the morning

Checking off below as they were previously deployed and already in PROD.
#23807
#24111
#24173
#24405
#24414
#24479
#24493
#24541
#24542
#25401
#25429
#25458
#25519
#25521
#25529
#25565
#25579
#25590
#25605
#25618
#25624
#25652
#25654
#25659
#25660
#25672
#25675
#25700
#25708
#25742
#25743
#25757
#25758
#25762
#25782
#25816
#25847
#25866
#25873
#25876
#25882
#25900
#25907
#25911
#25912
#25914
#25921
#25924
#25955
#25957
#25958
#25959
#25981
#25986
#26042
#26045
#26055
#26057

[Beamanator]

Checking off internal QA for #25827

[mountiny]

Checking of this deploy blocker which is not a bug #26287 (comment)

[Julesssss]

Blocker https://github.com/Expensify/Expensify/issues/312346 was fixed here and is currently being CP'd. Once complete I'll check it off

[Julesssss]

The post-CP build just completed and version 1.3.59-1 is ready to test on all platforms (Android was fixed 🎉 )

[luacmartins]

Checking off #26273. Demoted to NAB

[luacmartins]

Checking off #26275. Demoted to NAB.

[luacmartins]

Checking off #26282. Demoted to NAB

[luacmartins]

Checking off #26286. Demoted to NAB

[luacmartins]

Checking off #26288. We merged/CPed a fix.

[luacmartins]

Checking off #26289. We merged/CPed a fix.

[luacmartins]

Checking off #26311. Not an issue.

[luacmartins]

Checking off #26292. We tested on staging and it's a pass.

[mvtglobally]

@luacmartins We are finishing up regression

Current summary
#20747 - pending validation on all platforms
#23063 is failing #26291
#24616 - pending validation on all platforms
#25815 - pending validation on all platforms
#25954 - PROD QA , ok to check off?
#25969 is failing #26313, repro in PROD.
Also we are not able to validate PR on Native apps. Ok to check off?
#26182 is failing #26289
#26105 (comment) do we need to QA?
#26293 - pending validation on all platforms

[luacmartins]

Checking off #26314. Repro in prod.

[luacmartins]

Checking off #26319. Demoted to NAB.

[luacmartins]

@mvtglobally thanks for the update! I checked off the applicable PRs. I also asked for internal validation of #26182

[luacmartins]

Checking off #26322. We merged/CPed a fix.

[luacmartins]

Checking off #24639 and #23063. @youssef-lr tested them on staging and they are a pass

[mvtglobally]

@luacmartins Regression is completed

Unchecked PRs
#20747 is failing #26354

[luacmartins]

Checking off #26354. Demoted to NAB since I can repro in prod.

[luacmartins]

Checklist is clear. Kicking off the deploy.

[luacmartins]