[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-06] [HOLD #37374][$1000] Text in some languages gets cut off at the bottom in composer on ios

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to a report
2. Paste this text in the composer: "समुद्री उल्लू"

Expected Result

The text should not be cut off

Actual Result

The bottom of the text is cut off

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.3.1
Reproducible in staging?: y
Reproducible in production?: y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

RPReplay_Final1682015045.MP4

Issue reported by: @esh-g
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1682015564506459
View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010070c4cda3fad328
• Upwork Job ID: 1650822186330116096
• Last Price Increase: 2023-04-25

Issue Owner

Current Issue Owner: @miljakljajic

[MelvinBot]

Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@arielgreen Whoops! This issue is 2 days overdue. Let's get this updated quick!

[arielgreen]

Reassigning

[MelvinBot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[conorpendergrast]

Thanks! Reproduced on iOS app

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~010070c4cda3fad328

[MelvinBot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[MelvinBot]

Triggered auto assignment to @cead22 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[esh-g]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Composer cuts off some text in other languages at the bottom.

What is the root cause of that problem?

We are using the style textAlignVertical: 'center' to center text in the composer.

App/src/styles/styles.js

Line 1512 in d19326e

textAlignVertical: 'center',

But this style is only available on android and doesn't work on iOS.

What changes do you think we should make in order to solve the problem?

The recommended alternative to textAlignVertical for iOS is just to add padding to the bottom for the TextInput
So, we need to add a padding of 2px at the bottom of the Composer which

Before

After

This can either be only on iOS platform or even on the styles.js file itself because it doesn't add much change to the appearance on other platforms as well. This might not look clean but is unfortunately the only way to manage vertical centring of text on iOS.

What alternative solutions did you explore? (Optional)

Another common workaround for this is to wrap the TextInput with a fixed height View which would look like this:

<View style={{height:200, width:200, justifyContent:"center", alignItems:"center"}}>
   <TextInput 
     multiline={true} 
     numberOfLines={10} 
     placeholder="Something useful" />
</View>

This is also a valid approach. Let me know if I should further elaborate on this 😇

[Pujan92]

I think there is an issue with the iOS textinput lineHeight facebook/react-native#28012

For default lineHeight also the text gets overlap/cut in iOS, adding screenshot of snack. Padding seems to be hack as it shows that cut text on the padding area.

[fedirjh]

@esh-g Your RCA analysis does not appear accurate to me. Your solution is a workaround, it doesn’t address the root cause.

[fedirjh]

I agree with @Pujan92, this issue should be fixed upstream.

[fabOnReact]

I reopened facebook/react-native#28012

[fabOnReact]

Update 5 June 2024

I reviewed and tested the regressions and none of them are related to my PR Expensify/react-native-live-markdown#350.

• upgrade react-native-live-markdown to 0.1.76 #42454 (comment) The regression on iOS is not caused by my changes.
• Chat - For quote, live markdown is not shown #42755 My changes are iOS only
• [$250] Android-Room-After creating room, entering @ not showing contact suggestions #42766 My changes are iOS only

[miljakljajic]

@fabOnReact @fedirjh I had to send you both new contracts, the old one expired. If you can accept them today and then message me in slack I'll get it paid before the end of the day!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @fabOnReact paid $(AMOUNT) via Upwork (LINK)
• ROLE: @fedirjh paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@miljakljajic)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1650822186330116096/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[fabOnReact]

Update 10 June 2024

• react-native-live-markdown was updated with PR [CP Staging] Bump react-native-live-markdown to 0.1.82 #43255
• The issue is fixed in Expensify (tests included here)
• issuecomment-2156650468 and issuecomment-2155526850 are not related to PR 350, but the revert of PR 377 and bumped react-native-live-markdown from 0.82 to 0.83

[miljakljajic]

@fabOnReact paid

@fedirjh please accept the offer

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Bump react-native-live-markdown to 0.1.82 #43255

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @fabOnReact requires payment (Needs manual offer from BZ)
• @fedirjh requires payment (Needs manual offer from BZ)
• @esh-g requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Bump react-native-live-markdown to 0.1.82 #43255

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @fabOnReact requires payment (Needs manual offer from BZ)
• @fedirjh requires payment (Needs manual offer from BZ)
• @esh-g requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[miljakljajic]

C+ and C paid

[fedirjh]

@miljakljajic I wasn't yet paid for this one, can I decline Upwork offer and request payment in newDot?

[fedirjh]

@miljakljajic friendly bump. I have accepted upwork offer and am still awaiting the payment.

[miljakljajic]

Sorry for missing this @fedirjh - its all paid now