Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mount whole host drive ( "/") into containers #786

Open
kilrau opened this issue Nov 16, 2020 · 3 comments
Open

Don't mount whole host drive ( "/") into containers #786

kilrau opened this issue Nov 16, 2020 · 3 comments
Assignees
Labels
P2 mid priority question Further information is requested

Comments

@kilrau
Copy link
Contributor

kilrau commented Nov 16, 2020

Is your feature request related to a problem? Please describe.
Mounting the whole host drive into utils, causes issues on several operating systems and is not great from a security perspective. We are currently doing this to be able to check availability of the backup path on start of utils and prompt user to change if not available.

Describe the solution you'd like

  • mount backup path only after user entered backup path in flow
  • mount .xud-docker path and potentially different network paths as per xud-docker.conf in subsequent step
@kilrau kilrau added question Further information is requested P2 mid priority labels Nov 16, 2020
@reliveyy
Copy link
Collaborator

reliveyy commented Nov 16, 2020

mount backup path only after user entered backup path in flow

@kilrau You cannot append new volumes on a running contianer thus why we need to mount "/" into utils.

@kilrau
Copy link
Contributor Author

kilrau commented Nov 16, 2020

Aware, so there will be container restarts needed whenever something like backup path or network path changes.

@reliveyy
Copy link
Collaborator

reliveyy commented Nov 16, 2020

Aware, so there will be container restarts needed whenever something like backup path or network path changes.

Yes. But we also map "/" into xud container too. So there is no restart required for xud in the past. @kilrau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 mid priority question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants