Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

Previously found Decl should be linked right after create #506

Open
martong opened this issue Oct 12, 2018 · 1 comment
Open

Previously found Decl should be linked right after create #506

martong opened this issue Oct 12, 2018 · 1 comment

Comments

@martong
Copy link

martong commented Oct 12, 2018

Import starts with a lookup and then we create a new Decl. Then in certain cases (e.g. CXXConstructorDecl) we further import other Decls (base classes, members through CXXConstructorDecl::inits()) before connecting the redecl chain.
During those in-between imports structural eq fails because the canonical decl is different.

Currently this problem impacts only CXXConstructorDecl, however we plan to properly import the redecl chains in other kind of Decls too. Thus, we should add a new PrevDecl parameter to GetImportedOrCreateDecl on a long term.

@martong martong added this to the okt 11 milestone Oct 12, 2018
@dkrupp dkrupp modified the milestones: okt 11, okt 25, 1st November Oct 18, 2018
@martong
Copy link
Author

martong commented Oct 26, 2018

This implies that first we have to implement the import of the redecl chains for all nodes. E.g. EnumDecl, VarTemplateDecl, and lot of other nodes still do not handle the redecl chain properly.

@martong martong modified the milestone: 1st November Oct 26, 2018
@dkrupp dkrupp modified the milestones: 1st November, Nov 22 Nov 15, 2018
@dkrupp dkrupp removed this from the Nov 22 milestone Nov 22, 2018
@martong martong added task and removed ASTImporter labels Nov 22, 2018
@martong martong removed the task label May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants