-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multithreading to FiOne #1545
Open
ccuser44
wants to merge
15
commits into
Epix-Incorporated:master
Choose a base branch
from
ccuser44:patch-10
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccuser44
changed the title
Add multithreading to FiOne. **Officially the first ever per function multithreading implementation in Lua that works out of the box without libraries**
Add multithreading to Loadstring. **Officially the first ever per function multithreading implementation in Lua that works out of the box without libraries**
Jun 2, 2024
ccuser44
changed the title
Add multithreading to Loadstring. **Officially the first ever per function multithreading implementation in Lua that works out of the box without libraries**
Add multithreading to FiOne. **Officially the first ever per function multithreading implementation in Lua that works out of the box without libraries**
Jun 2, 2024
ccuser44
changed the title
Add multithreading to FiOne. **Officially the first ever per function multithreading implementation in Lua that works out of the box without libraries**
Add multithreading to FiOne
Jun 2, 2024
SUPER_SECRET_ADONIS_MULTITHREAD_PREFIX_ |
Needs proof of functionality |
I say we do all compiler/interpreter related stuff on a separate repository which is then included here as a git module. |
just add that into adonis. ez |
WOOHOO! NEW COMMITS! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multithreading to FiOne. Officially the first ever per function multithreading implementation in Lua that works out of the box without libraries
Function is multithreaded when function name is prefixed with
SUPER_SECRET_ADONIS_MULTITHREAD_PREFIX_
.Only
(local)? function NAME(...)
is detected, notNAME = function(...)
.Only uses one different thread per function for now. Functions yields until multithreaded function returns or errors
Upval mutation, env mutations, calling closures outside threaded context, cross thread metatables, Instance interactions and cross thread table changes have all undefined behavior
Question: Why does Adonis need this?
Answer: You can't create cloned FiOne runners without hacking Adonis, this makes multithreading possible without hacking Adonis. Making some form of multithreading possible in Adonis without hacking Adonis itself is very nice