Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI testing for EnzymeCore #2009

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

gdalle
Copy link
Contributor

@gdalle gdalle commented Oct 23, 2024

As discussed in #1979, this PR adds a CI job for testing EnzymeCore and reporting coverage, following the model of EnzymeTestUtils.
It also skips two tests which seem broken but were never run before so we didn't know.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.41%. Comparing base (037dfed) to head (7d3ca93).
Report is 178 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2009      +/-   ##
==========================================
+ Coverage   67.50%   69.41%   +1.90%     
==========================================
  Files          31       35       +4     
  Lines       12668    14920    +2252     
==========================================
+ Hits         8552    10356    +1804     
- Misses       4116     4564     +448     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vchuravy vchuravy merged commit 647b13c into EnzymeAD:main Oct 23, 2024
13 of 27 checks passed
@gdalle gdalle deleted the gd/enzymecore_test branch October 23, 2024 12:46
matrix:
version:
- '1.10'
- ~1.11.0-0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just be 1.11

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the same versions as for EnzymeTestUtils, feel free to change those in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants