Utilities for splitting and unsplitting mode objects #1979
Conversation
| @@ -384,7 +384,7 @@ Subtype of [`Mode`](@ref) for split reverse mode differentiation, to use in [`au | |||
| - [`set_abi`](@ref) | |||
| - [`ReverseSplitModified`](@ref), [`ReverseSplitWidth`](@ref) | |||
| """ | |||
| struct ReverseModeSplit{ReturnPrimal,ReturnShadow,Width,RuntimeActivity,ModifiedBetween,ABI,Holomorphic,ErrIfFuncWritten,ShadowInit} <: Mode{ABI, ErrIfFuncWritten,RuntimeActivity} end | |||
| struct ReverseModeSplit{ReturnPrimal,ReturnShadow,RuntimeActivity,Width,ModifiedBetween,ABI,Holomorphic,ErrIfFuncWritten,ShadowInit} <: Mode{ABI, ErrIfFuncWritten,RuntimeActivity} end | |||
There was a problem hiding this comment.
As explained in this comment, this just fixes a typo that doesn't change functionality but makes the code harder to understand. Semantically, the runtime activity parameter comes before width in all the uses of this struct, even though they are "labelled" wrong here.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1979 +/- ##
==========================================
+ Coverage 67.50% 69.46% +1.95%
==========================================
Files 31 35 +4
Lines 12668 14929 +2261
==========================================
+ Hits 8552 10370 +1818
- Misses 4116 4559 +443 ☔ View full report in Codecov by Sentry. |
|
Silly question: do the tests of EnzymeCore ever run? Because that's where I put these new checks |
|
....good question. Probably we should just add a CI job for EnzymeCore |
|
See #2009 |
|
Is anything more needed on my end? |
|
Gentle bump on this one @wsmoses |
Fix #1938
I can also add more tests for these mode modifiers in a separate PR, if you're interested