-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Distributions integration tests #1819
base: main
Are you sure you want to change the base?
Add Distributions integration tests #1819
Conversation
c9ab2eb
to
a879421
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1819 +/- ##
==========================================
+ Coverage 67.50% 70.02% +2.51%
==========================================
Files 31 44 +13
Lines 12668 15660 +2992
==========================================
+ Hits 8552 10966 +2414
- Misses 4116 4694 +578 ☔ View full report in Codecov by Sentry. |
This is ready for review. I've marked all failing tests as broken and opened issues for them. The univariate distributions are doing well, except for some missing foreign calls that were already known. There's still quite a lot of breakage for multivariate and matrix variate distributions. Here are all the relevant issues:
EDIT: |
Fixed the two issues you pointed out. Tests now locally crash julia with |
Commented out the one that crashes and made an issue about it. Tests pass locally again, ready for another look, @wsmoses. |
I'm unable to reproduce locally that last test failure, despite using the same Julia and dependency versions. Could something here be platform dependent? |
Maybe consider running these integration tests in a broader range of platforms by default. |
58ca3ad
to
74fd042
Compare
177b731
to
5732d43
Compare
Tests pass locally for me, but hang for 6 hours on CI and time out. @wsmoses any ideas for what might be going on? Would you have a Linux machine to test this locally? |
Runs
logpdf
on a lot of different distributions, compares against FiniteDifferences.Currently generating a lot of failures. Need to investigate which ones should be reported as bugs, which ones should just be marked as broken because of e.g. missing foreign calls.
Largely copied from similar tests in Tapir: https://github.com/compintell/Tapir.jl/blob/main/test/integration_testing/distributions.jl