Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Distributions integration tests #1819

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

mhauru
Copy link
Contributor

@mhauru mhauru commented Sep 13, 2024

Runs logpdf on a lot of different distributions, compares against FiniteDifferences.

Currently generating a lot of failures. Need to investigate which ones should be reported as bugs, which ones should just be marked as broken because of e.g. missing foreign calls.

Largely copied from similar tests in Tapir: https://github.com/compintell/Tapir.jl/blob/main/test/integration_testing/distributions.jl

@wsmoses wsmoses force-pushed the mhauru/distributions-integration-tests branch 2 times, most recently from c9ab2eb to a879421 Compare September 28, 2024 05:00
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.02%. Comparing base (037dfed) to head (7a75271).
Report is 213 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1819      +/-   ##
==========================================
+ Coverage   67.50%   70.02%   +2.51%     
==========================================
  Files          31       44      +13     
  Lines       12668    15660    +2992     
==========================================
+ Hits         8552    10966    +2414     
- Misses       4116     4694     +578     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsmoses
Copy link
Member

wsmoses commented Sep 29, 2024

@mhauru @yebai from the quadgk version incompatability, I think this should just be done in DistributionsAD.jl?

In any case, open any issues that persist and we'll get them fixed quickly

@mhauru mhauru marked this pull request as ready for review October 22, 2024 14:55
@mhauru
Copy link
Contributor Author

mhauru commented Oct 23, 2024

Fixed the two issues you pointed out. Tests now locally crash julia with Illegal instruction, not sure why, probably something that has changed on main. Will investigate tomorrow.

@mhauru
Copy link
Contributor Author

mhauru commented Oct 24, 2024

Commented out the one that crashes and made an issue about it. Tests pass locally again, ready for another look, @wsmoses.

@mhauru mhauru requested a review from wsmoses October 24, 2024 10:19
@mhauru
Copy link
Contributor Author

mhauru commented Oct 28, 2024

I'm unable to reproduce locally that last test failure, despite using the same Julia and dependency versions. Could something here be platform dependent?

@yebai
Copy link

yebai commented Nov 1, 2024

I'm unable to reproduce locally that last test failure, despite using the same Julia and dependency versions. Could something here be platform dependent?

Maybe consider running these integration tests in a broader range of platforms by default.

@wsmoses wsmoses force-pushed the mhauru/distributions-integration-tests branch from 58ca3ad to 74fd042 Compare November 4, 2024 14:57
@wsmoses wsmoses force-pushed the mhauru/distributions-integration-tests branch from 177b731 to 5732d43 Compare November 6, 2024 17:44
@mhauru
Copy link
Contributor Author

mhauru commented Nov 7, 2024

Tests pass locally for me, but hang for 6 hours on CI and time out. @wsmoses any ideas for what might be going on? Would you have a Linux machine to test this locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants