Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage_dbserver service handler fails when patroni is used #509

Open
treenerd opened this issue Mar 24, 2023 · 3 comments
Open

manage_dbserver service handler fails when patroni is used #509

treenerd opened this issue Mar 24, 2023 · 3 comments

Comments

@treenerd
Copy link
Contributor

Hi edb community;

I have tested the patroni part a bit and realized that I got some issues within my playbooks when manage_dbserver handler tries to reload postgresql on a node.
Because patroni creates the service like postgresql-{pg_version}-patroni and manage_dbserver uses the lookup for pg_service which doesn't recognize that patroni is configured on that node, the reload will point to the wron service on that node.
So within the lookup plugin the information about patroni is completely missing.

I don't have that much experience yet with patroni, but it would be interessting how it is recommended to reload, restart nodes configured with patroni when the edb roles are used.

  • Is it suggested to do this manualy and ignore the failure of manage_dbserver in that cases?
  • Is any special configuration, attribute needed so that ansible does it the right way?
  • Or is it just a missing feature inside the lookup plugin?

I also think, that even if ansible reloads postgresql-12-patroni a manual step will be needed, because inside patroni it is just marked to be reloaded/restarted. So it has to be scheduled or triggered within patroni to make things really happen.

If it is welcome I can create a improvment of the lookup plugin and add functionality for patroni.
I'm open for discussions.

Best Regards

@vibhorkumar123
Copy link
Contributor

Hi @treenerd , I appreciate you for pointing out the missing piece in the lookup plugin. Our team values contributions, and we're always excited to showcase them in our releases. Please feel to contribute to this project.

@vibhorkumar123
Copy link
Contributor

@treenerd Would you like to submit a patch for per the previous comment?

@treenerd
Copy link
Contributor Author

Hi @vibhorkumar123

Sorry, but I thought I would have time to create a patch, but I didn't had time yet.
I also focus more on kubernetes related stuff like the cloudnativePG and reduced my efforts in ansible roles a bit at the moment.

So from my side there are not the resources to provide a patch at the moment and test everything in deep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants