CMDCT-4254 - minor tweaks to serverless v4 implementation #97
+24
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peoplespete
force-pushed
the
cmdct-4254
branch
4 times, most recently
from
362756e to
1f0a04e
Compare
peoplespete
force-pushed
the
cmdct-4254
branch
from
1f0a04e to
ffa828f
Compare
|
Code Climate has analyzed commit 9257dd9 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 93.6%. View more on Code Climate. |
peoplespete
force-pushed
the
cmdct-4254
branch
from
9257dd9 to
ffa828f
Compare
peoplespete
commented
Jan 23, 2025
| @@ -54,6 +54,9 @@ provider: | |||
| name: aws | |||
| runtime: nodejs20.x | |||
| region: us-east-1 | |||
| stackTags: | |||
There was a problem hiding this comment.
This will solve an issue where app-api stacks were not being deleted by destroy.
peoplespete
commented
Jan 23, 2025
| @@ -132,6 +132,9 @@ resources: | |||
| RestrictPublicBuckets: true | |||
| VersioningConfiguration: | |||
| Status: Enabled | |||
| LoggingConfiguration: | |||
There was a problem hiding this comment.
I missed this in my first attempt at converting HCBS to v4 of serverless.
peoplespete
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are a couple issues that came up related to the HCBS implementation of v4 so this is a mop up of outstanding problems.
Related ticket(s)
CMDCT-4254
How to test
You can log into the application here:
https://d32y65zs9733uw.cloudfront.net/
Important updates
NA
Author checklist
convert to a different template: test → val | val → prod