Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance jump-to-file experience in PR #248

Open
EnixCoda opened this issue Jul 6, 2022 · 2 comments
Open

Enhance jump-to-file experience in PR #248

EnixCoda opened this issue Jul 6, 2022 · 2 comments
Labels
enhancement

Comments

@EnixCoda
Copy link
Owner

EnixCoda commented Jul 6, 2022

Clicking on PR file items only triggers a whole-page reload instead of scrolling to the corresponding file.

It can be fixed by removing data-turbo-frame="repo-content-turbo-frame" from the file items.
@EnixCoda EnixCoda added the bug label Jul 6, 2022
@EnixCoda
Copy link
Owner Author

Partially fixed in v3.8.0

@EnixCoda EnixCoda changed the title Jump to file does not work in PR Enhance jump-to-file experience in PR Jul 18, 2022
@EnixCoda EnixCoda added enhancement and removed bug labels Jul 18, 2022
@EnixCoda
Copy link
Owner Author

EnixCoda commented Jul 18, 2022 •
edited
Loading

Now jump to file is not very stable, it could add dup records to browser history, user would have to go back for more times than expected

Example steps:

  1. open a PR, e.g. Test/multiple changes #197
  2. Go to files page via Gitako sidebar
  3. Click another file item in GItako sidebar, page focus should be update to the new item
  4. Navigate back (e.g. via browser back button)
  5. Browser's address bar would become https://github.com/EnixCoda/Gitako/pull/197/files, which has no hash appended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EnixCoda