Improvement of types PipeSimple and PipeLinepackSimple
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a few typos
reverse mistake in list notation
Fixed typo
espenfb
reviewed
Aug 21, 2024
Co-authored-by: espenfb <[email protected]>
I added all suggestions for the typos as they make sense in my opinion. |
espenfb
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used so far as
@kwdeffor bothPipeSimpleandPipeLinepackSimple. This approach required specifying all field names in the case one wanted to omit either the fielddirectionsordata. As this require an unnecessary amount of typing, it was changed to a standard composite type.The field direction is still existing, but it is no longer possible to specify it. Previously, we used warnings in cases in which the value was not 1 as
EMGdoes not support bidirectional pipeline transport. This potential source of error was now removed through the application of inner constructors.Once this PR is merged, we will register v0.10 of EMG.