From 3b3640756077a0d7e9e83de169292c24a35d94e1 Mon Sep 17 00:00:00 2001 From: Vincent Date: Mon, 9 Sep 2024 17:44:16 +0100 Subject: [PATCH] fix: ensure only non-None JSON objects are appended to the chart data --- src/endstone_bstats/_base.py | 4 +++- src/endstone_bstats/_metrics.py | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/endstone_bstats/_base.py b/src/endstone_bstats/_base.py index 185dcfc..fd54412 100644 --- a/src/endstone_bstats/_base.py +++ b/src/endstone_bstats/_base.py @@ -167,7 +167,9 @@ def _submit_data(self): chart_data = [] for chart in self._custom_charts: try: - chart_data.append(chart._get_request_json_object()) + chart_json = chart._get_request_json_object() + if chart_json is not None: + chart_data.append(chart_json) except Exception as e: if self._log_errors: self.log_error( diff --git a/src/endstone_bstats/_metrics.py b/src/endstone_bstats/_metrics.py index ad57658..82c86af 100644 --- a/src/endstone_bstats/_metrics.py +++ b/src/endstone_bstats/_metrics.py @@ -39,7 +39,7 @@ def __init__(self, plugin: Plugin, service_id: int) -> None: ) self.add_custom_chart( - SimplePie("endstone_version", lambda: self._server.version) + SimplePie("endstone_version", lambda: self._plugin.server.version) ) self.add_custom_chart(DrilldownPie("python_version", self._get_python_version))