Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] NON_ELEMENTAL_UPGRADE_BONUS doesn't work #876

Open
1 task done
touhouzun opened this issue Aug 18, 2024 · 0 comments
Open
1 task done

[Bug] NON_ELEMENTAL_UPGRADE_BONUS doesn't work #876

touhouzun opened this issue Aug 18, 2024 · 0 comments
Labels
bug Anything that isn't working how it's supposed to Needs Triage

Comments

@touhouzun
Copy link

touhouzun commented Aug 18, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Observed behaviour

2024-08-18_16 02 43
2024-08-18_16 13 50
2024-08-18_16 19 23
Couldn't apply melee_upgrade or other upgrades to none-elemental wand any further like these screenshots.

Expected behaviour

None-elemental master wand can be applied with up to 12 upgrades, instead of 9.

		// Special upgrades
		Item specialUpgrade = upgrade.getItem();

		int maxUpgrades = this.tier.upgradeLimit;
		if(this.element == Element.MAGIC) maxUpgrades += Constants.NON_ELEMENTAL_UPGRADE_BONUS;

		if(WandHelper.getTotalUpgrades(wand) < maxUpgrades
				&& WandHelper.getUpgradeLevel(wand, specialUpgrade) < Constants.UPGRADE_STACK_LIMIT){

Steps to reproduce

  1. take a none-elemental wand and several upgrades from the inventory.
  2. upgrade the wand to maximum.

Crashlog

No response

Environment (Singleplayer/Server, etc.)

Singleplayer

Mod version

4.3.14

Minecraft version

1.12.2

Forge version

1.12.2 - 14.23.5.2860

Other mods

None in the second and third screenshots.

@touhouzun touhouzun added bug Anything that isn't working how it's supposed to Needs Triage labels Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Anything that isn't working how it's supposed to Needs Triage
Projects
None yet
Development

No branches or pull requests

1 participant