Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell Cast Command does not implement finishCasting method #858

Open
1 task done
ipdnaeip opened this issue Aug 31, 2023 · 0 comments
Open
1 task done

Spell Cast Command does not implement finishCasting method #858

ipdnaeip opened this issue Aug 31, 2023 · 0 comments
Labels
bug Anything that isn't working how it's supposed to Needs Triage

Comments

@ipdnaeip
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Observed behaviour

When casting a continuous spell using the command system, if a spell has an effect that is supposed to go off after it is over, it will not activate.

This is not as much a bug as a missing feature as it is not implemented in the spell cast command code.

Expected behaviour

Spells should activate their finishCasting effect once the spell is finished casting

Steps to reproduce

Only grapple implements this method in the base mod and it does not have a very noticeable effect. In the Wizardry Next Generation addon, it affects the antigravity spell in that the part in which it applies levitation never activates.

Crashlog

No response

Environment (Singleplayer/Server, etc.)

Singleplayer

Mod version

4.3.7

Minecraft version

1.12.2

Forge version

1.12.2 14.23.5.2859

Other mods

Wizardry Next Generation

@ipdnaeip ipdnaeip added bug Anything that isn't working how it's supposed to Needs Triage labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Anything that isn't working how it's supposed to Needs Triage
Projects
None yet
Development

No branches or pull requests

1 participant