From 796b7a637ab4df2096c58e0bde567ced94cbe9cb Mon Sep 17 00:00:00 2001 From: Adrien Crivelli Date: Sat, 4 Dec 2021 00:35:29 +0900 Subject: [PATCH] Multiple asserts are only available since PHP 7.3 This is unfortunately because multiple asserts are only fixed since laminas-permissions-acl 2.9.0 and that version only support PHP 7.3. So that forces us to not support PHP 7.2 for that specific features. --- .github/workflows/main.yml | 7 +++++-- tests/Acl/AclTest.php | 3 +++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index bac6bfd..167e2ef 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -31,8 +31,8 @@ jobs: key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} restore-keys: ${{ runner.os }}-composer- - - name: Remove lock for PHP 8 - if: matrix.php-version == '8.0' + - name: Remove lock for newer PHP + if: matrix.php-version != '7.2' run: rm composer.lock && composer require symfony/cache - name: Install dependencies @@ -120,6 +120,9 @@ jobs: key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} restore-keys: ${{ runner.os }}-composer- + - name: Remove lock for newer PHP + run: rm composer.lock && composer require symfony/cache + - name: Install dependencies run: composer install diff --git a/tests/Acl/AclTest.php b/tests/Acl/AclTest.php index eec68c0..0dd2e57 100644 --- a/tests/Acl/AclTest.php +++ b/tests/Acl/AclTest.php @@ -59,6 +59,9 @@ public function __construct() self::assertSame('Non-logged user with role anonymous is not allowed on resource "User#null" with privilege "update"', $acl->getLastDenialMessage()); } + /** + * @requires PHP 7.3 + */ public function testMultipleReasons(): void { $acl = new class() extends Acl {