Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated data too simple to create meaningful esmvaltool tests/plots #6

Open
bouweandela opened this issue Oct 20, 2017 · 0 comments

Comments

@bouweandela
Copy link
Member

Currently there are only two options for generating data:

  1. random numbers from a uniform distribution between 0 and 1
  2. constant

Option 1) is almost useless, because physical quantities are typically defined at some other scale than between 0 and 1.
Option 2) does not allow creating e.g. contour plots and it is probably also very insensitive to changes in the output, .e.g you couldn't detect a change in regridding using this.

It would probably be good to add more interesting ways of generating data.

Also, the current implementation is very inflexible. The only way to get other data in, is to either override the private method _get_variable_data or to first generate the file with some useless data, and then open it again to change the values. A more flexible approach could be to make the Model2 or Model3 object available as a context manager (just like the netCDF4.Dataset object that it inherits from).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant