Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md code typo #27

Open
hadfieldnz opened this issue Nov 7, 2019 · 1 comment
Open

README.md code typo #27

hadfieldnz opened this issue Nov 7, 2019 · 1 comment

Comments

@hadfieldnz
Copy link
Contributor

In README.md for the installation of the scrip extension we have

$ make DEVELOP=1 PREFIX=$PREFIX install
$ mv -vf scrip*.so ../../../pyroms
scrip.cpython-37m-x86_64-linux-gnu.so -> ../../../pyroms/scrip.cpython-37m-x86_64-linux-gnu.so

That last mv command should not have a dollar sign in front: it's something make runs. Also the current makefile has a cp command, which is more in the spirit of "make install". So it should be

$ make DEVELOP=1 PREFIX=$PREFIX install
cp -vf scrip*.so ../../../pyroms
scrip.cpython-37m-x86_64-linux-gnu.so -> ../../../pyroms/scrip.cpython-37m-x86_64-linux-gnu.so

@kshedstrom
Copy link
Collaborator

I noticed that make had run the cp command so that I didn't have to. I found it confusing that the README seemed to be telling me to run it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants