Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCPP-ize get_hydrostatic_energy and remove cam_thermo_formula dependency from check_energy_chng #157

Open
jimmielin opened this issue Nov 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jimmielin
Copy link
Member

As brought up during the review of #145 (check_energy CCPP-ization), the dependency on cam_thermo_formula in check_energy_chng run and timestep initialize:

I'm not sure how portable the formulas for different dycores are for models beyond CAM, and this doesn't seem to be as easy to work around as the dycore_energy_consistency_adjust_run situation where a different flag could be used. I would suggest perhaps we could leave it as-is so we could CCPP-ize get_hydrostatic_energy and the corresponding formula flags in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To Do
Development

No branches or pull requests

1 participant