Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aux_clm "clm-basic" tests fail as of ctsm5.3.0 because they need c13 in finidat #2787

Closed
slevis-lmwg opened this issue Sep 25, 2024 · 5 comments · Fixed by #2829
Closed

aux_clm "clm-basic" tests fail as of ctsm5.3.0 because they need c13 in finidat #2787

slevis-lmwg opened this issue Sep 25, 2024 · 5 comments · Fixed by #2829
Assignees
Labels
bfb bit-for-bit bug something is working incorrectly done Issues whose closing PR is done but not yet merged (pending test re-run ok) priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations testing additions or changes to tests

Comments

@slevis-lmwg
Copy link
Contributor

Brief summary of bug

During ctsm5.3.0 testing, three aux_clm tests failed in the RUN phase because they were missing c13 in the finidat:

SMS_Lm1.f10_f10_mg37.I1850Clm50BgcCropCmip6waccm.derecho_gnu.clm-basic
ERS_Ly3.f10_f10_mg37.I1850Clm50BgcCropCmip6.derecho_intel.clm-basic
SMS_Ld2_D_PS.f09_g17.I1850Clm50BgcCropCmip6.derecho_intel.clm-basic_interp

General bug information

CTSM version you are using: ctsm5.3.0

Does this bug cause significantly incorrect results in the model's science? No

Configurations affected: /basic and /basic_interp testmods directories

Details of bug

Original post reporting the problem:
#2500 (comment)

@slevis-lmwg slevis-lmwg self-assigned this Sep 25, 2024
@slevis-lmwg slevis-lmwg added bug something is working incorrectly testing additions or changes to tests bfb bit-for-bit next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Sep 25, 2024
@ekluzek
Copy link
Collaborator

ekluzek commented Sep 25, 2024

Another way to handle this would be to update these tests to clm6_0. And I think that's actually what we should do to use the new clm6_0 finidat files as well as move more testing from Clm50 to Clm60.

@ekluzek ekluzek added this to the cesm3_0_beta04 milestone Sep 25, 2024
@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Sep 25, 2024

I had to update

--- a/cime_config/config_compsets.xml
+++ b/cime_config/config_compsets.xml
@@ -197,15 +197,15 @@
   <!-- Primarily for testing the CMIP6DECK compset option -->
   <!-- Use the CMIP6 version (clm5_0) -->
   <compset>
-    <alias>I1850Clm50BgcCropCmip6</alias>
-    <lname>1850_DATM%GSWP3v1_CLM50%BGC-CROP-CMIP6DECK_SICE_SOCN_MOSART_SGLC_SWAV</lname>
+    <alias>I1850Clm60BgcCropCmip6</alias>
+    <lname>1850_DATM%GSWP3v1_CLM60%BGC-CROP-CMIP6DECK_SICE_SOCN_MOSART_SGLC_SWAV</lname>
   </compset>
 
   <!-- Primarily for testing the CMIP6WACCMDECK compset option -->
   <!-- Use the CMIP6 version (clm5_0) -->
   <compset>
-    <alias>I1850Clm50BgcCropCmip6waccm</alias>
-    <lname>1850_DATM%GSWP3v1_CLM50%BGC-CROP-CMIP6WACCMDECK_SICE_SOCN_MOSART_SGLC_SWAV</lname>
+    <alias>I1850Clm60BgcCropCmip6waccm</alias>
+    <lname>1850_DATM%GSWP3v1_CLM60%BGC-CROP-CMIP6WACCMDECK_SICE_SOCN_MOSART_SGLC_SWAV</lname>

Now troubleshooting new error:
ERROR: No description found for comp_class lnd matching compsetname 1850_DATM%GSWP3v1_CLM60%BGC-CROP-CMIP6DECK_SICE_SOCN_MOSART_SGLC_SWAV_SESP in file /glade/derecho/scratch/slevis/temp_work/new_rawdata/cime_config/config_component.xml, expected match in ['CLM60'] % ['SP', 'SP-NOANTHRO', 'BGC-NOANTHRO', 'BGC', 'BGC-CROP', 'FATES', 'FATES-SP', 'NWP-SP', 'NWP-BGC-CROP']

@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Sep 25, 2024

I got past the last error with this update

--- a/cime_config/config_component.xml
+++ b/cime_config/config_component.xml
@@ -14,7 +14,7 @@
   <!-- Descriptions of all the different valid configurations for different model versions -->
   <description modifier_mode="1">
     <desc lnd="CLM45[%SP][%SP-VIC][%BGC][%BGC-CROP][%FATES][%BGCDV][%BGCDV-CROP]"                  >clm4.5:</desc>
-    <desc lnd="CLM50[%SP][%SP-VIC][%SP-NOANTHRO][%BGC-NOANTHRO][%BGC][%BGC-CROP][%FATES][%BGCDV][%BGCDV-CROP][%BGC-CROP-CMIP6DECK][%BGC-CROP-CMIP6WACCMDECK][%NWP-SP][%NWP-BGC-CROP]">clm5.0:</desc>
+    <desc lnd="CLM60[%SP][%SP-VIC][%SP-NOANTHRO][%BGC-NOANTHRO][%BGC][%BGC-CROP][%FATES][%BGCDV][%BGCDV-CROP][%BGC-CROP-CMIP6DECK][%BGC-CROP-CMIP6WACCMDECK][%NWP-SP][%NWP-BGC-CROP]">clm6.0:</desc>
     <desc lnd="CLM51[%SP][%SP-NOANTHRO][%BGC-NOANTHRO][%BGC][%BGC-CROP][%FATES][%FATES-SP][%NWP-SP][%NWP-BGC-CROP]">clm5.1:</desc>
     <desc lnd="CLM60[%SP][%SP-NOANTHRO][%BGC-NOANTHRO][%BGC][%BGC-CROP][%FATES][%FATES-SP][%NWP-SP][%NWP-BGC-CROP]">clm6.0:</desc>
     <desc option="SP"              >Satellite phenology:</desc>
@@ -367,10 +367,10 @@
     <values match="last">
       <value                  compset="_CLM60%[^_]*FATES-SP[%_]"      >$COMP_ROOT_DIR_LND/cime_config/usermods_dirs/fates_sp</value>
       <value                  compset="_CLM51%[^_]*FATES-SP[%_]"      >$COMP_ROOT_DIR_LND/cime_config/usermods_dirs/fates_sp</value>
-      <value                  compset="_CLM50%[^_]*CMIP6DECK[%_]"     >$COMP_ROOT_DIR_LND/cime_config/usermods_dirs/cmip6_deck</value>
-      <value grid="l%1.9x2.5" compset="_CLM50%[^_]*CMIP6DECK[%_]"     >$COMP_ROOT_DIR_LND/cime_config/usermods_dirs/cmip6_nociso_deck</value>
-      <value                  compset="_CLM50%[^_]*CMIP6WACCMDECK[%_]">$COMP_ROOT_DIR_LND/cime_config/usermods_dirs/cmip6_waccm_deck</value>
-      <value grid="l%1.9x2.5" compset="_CLM50%[^_]*CMIP6WACCMDECK[%_]">$COMP_ROOT_DIR_LND/cime_config/usermods_dirs/cmip6_waccm_nociso_deck</value>
+      <value                  compset="_CLM60%[^_]*CMIP6DECK[%_]"     >$COMP_ROOT_DIR_LND/cime_config/usermods_dirs/cmip6_deck</value>
+      <value grid="l%1.9x2.5" compset="_CLM60%[^_]*CMIP6DECK[%_]"     >$COMP_ROOT_DIR_LND/cime_config/usermods_dirs/cmip6_nociso_deck</value>
+      <value                  compset="_CLM60%[^_]*CMIP6WACCMDECK[%_]">$COMP_ROOT_DIR_LND/cime_config/usermods_dirs/cmip6_waccm_deck</value>
+      <value grid="l%1.9x2.5" compset="_CLM60%[^_]*CMIP6WACCMDECK[%_]">$COMP_ROOT_DIR_LND/cime_config/usermods_dirs/cmip6_waccm_nociso_deck</value>

Three tests submitted:
PASS SMS_Lm1.f10_f10_mg37.I1850Clm60BgcCropCmip6waccm.derecho_gnu.clm-basic
PASS SMS_Ld2_D_PS.f09_g17.I1850Clm60BgcCropCmip6.derecho_intel.clm-basic_interp
PASS ERS_Ly3.f10_f10_mg37.I1850Clm60BgcCropCmip6.derecho_intel.clm-basic

Erik's suggestion seems successful!

@slevis-lmwg
Copy link
Contributor Author

Next step: Open PR

@ekluzek ekluzek added the priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations label Sep 27, 2024
@ekluzek
Copy link
Collaborator

ekluzek commented Sep 27, 2024

@wwieder @slevis-lmwg and I discussed this one. And we realized that this is pointing at the cmip6deck experiments for clm5_0 (which is what cmip6 was run with). We don't think that is useful any more to maintain -- however starting to migrate these to cmip7 deck experiments DOES make sense. So we plan to label these as cmip7 with clm6_0, but leave them mostly as they are. As we find out what the cmip7 deck is going to look like -- we'll evolve them to look like the cmip7 deck. Let us know if you'd like to discuss this further if you aren't sure about that plan.

@ekluzek ekluzek removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 27, 2024
@slevis-lmwg slevis-lmwg added the done Issues whose closing PR is done but not yet merged (pending test re-run ok) label Oct 7, 2024
@samsrabin samsrabin linked a pull request Oct 11, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit bug something is working incorrectly done Issues whose closing PR is done but not yet merged (pending test re-run ok) priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations testing additions or changes to tests
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants