sending pbl_utils the wrong definition of 'theta' in clubb_intr.F90

[adamrher]

What happened?

During one of my clubb cleanup PRs, I introduced a bug by changing the calculation of theta that is sent to pbl_utils from clubb_intr.F90.

    ! --------------------------------------------------------------------------------- !
    !  DIAGNOSE THE PBL DEPTH                                                           !
    !  this is needed for aerosol code                                                  !
    ! --------------------------------------------------------------------------------- !
    do i=1,ncol
      do k=1,pver
         !use local exner since state%exner is not a proper exner
         th(i,k) = state1%t(i,k)*inv_exner_clubb(i,k)
         !thv should have condensate loading to be consistent with earlier def's in this module
         thv(i,k) = th(i,k)*(1.0_r8+zvir*state1%q(i,k,ixq) - state1%q(i,k,ixcldliq))
      enddo
    enddo

We should be using state%exner to compute th since that is the pbl version of exner, i.e., "not a proper exner". These vars th / thv are fed into pbl_utils, which requires them to computed using the pbl version of exner. This should impact the PBLH variable used elsewhere in the model (e.g., ZM).

What are the steps to reproduce the bug?

run any compset that uses clubb

What CAM tag were you using?

cam6_4_045

What machine were you running CAM on?

CISL machine (e.g. cheyenne)

What compiler were you using?

Intel

Path to a case directory, if applicable

No response

Will you be addressing this bug yourself?

Yes

Extra info

No response