Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webservice response and JSON schema #16

Open
damb opened this issue Apr 6, 2020 · 1 comment
Open

Webservice response and JSON schema #16

damb opened this issue Apr 6, 2020 · 1 comment
Assignees
Labels

Comments

@damb
Copy link
Contributor

damb commented Apr 6, 2020

This issue is a follow-up in response to an email from @Jollyfant:

Hi guys,
I don't think we ever changed the schema so it's the most recent version, although it has bugs because the output does not validate on the schema, apparently!


In the JSON schema we need to change for all enums, type: "string", and enum as a seperate object. Maybe an older version of JSON schema did it this way.


The schema should work for the option inlcude=all (all metrics must be returned) and for a single document in the returned array. But the webservice has some additional issues pulling these fields from the DB


  1.  nsamp (service) is called nsam (collector) in the database @ line 1037
  2.  long_record_read is not added to the client output @ line 1066
  3.  event in progress is not added to the client output @ line 1084

and all three are therefore not returned. So these could be fixed in the service.

Hope it helps fixing the bugs!

Best,
Mathijs

Thanks @Jollyfant for your input.

@damb damb added the bug label Apr 6, 2020
@jbienkowski jbienkowski self-assigned this Apr 6, 2020
@damb
Copy link
Contributor Author

damb commented Feb 26, 2021

@jbienkowski, any updates on this one, here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants