Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add realestate.com.au domains to MDFP #2022

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Conversation

ghostwords
Copy link
Member

Another session cookies issue (#1545).

Error report counts by date, exact blocked reastatic.net subdomain, and site domain:

+---------+----------------------+---------------------------+-------+
| ym      | blocked_fqdn         | fqdn                      | count |
+---------+----------------------+---------------------------+-------+
| 2018-05 | s1.rea.reastatic.net | www.realestate.com.au     |     4 |
| 2018-04 | s1.rea.reastatic.net | www.realestate.com.au     |    13 |
| 2018-03 | s2.rea.reastatic.net | www.realestate.com.au     |     8 |
| 2018-02 | s2.rea.reastatic.net | www.realestate.com.au     |     7 |
| 2018-01 | s2.rea.reastatic.net | www.realestate.com.au     |     1 |
...

@ghostwords ghostwords added the MDFP Multi-domain first parties: lists of domains that should be treated as related to each other label May 14, 2018
@ghostwords ghostwords requested a review from bcyphers May 14, 2018 17:25
@bcyphers
Copy link
Contributor

Any tips to reproduce? I've created an account on realestate.com.au, and I can see s1.rea.reastatic.net on that page after I log in (under "does not appear to be tracking"). I can also see reastatic.net subdomains on property.com.au, also marked as non-tracking, but I don't see them on any of the other sites.

@ghostwords
Copy link
Member Author

I visited https://www.realcommercial.com.au/for-sale and https://www.property.com.au/buy, which got me two strikes. Then I visited https://www.realestate.com.au and searched for something ("Sydney") and the results page got me three strikes. Debug output:

**** ACTION_MAP for reastatic
s1.pca.reastatic.net {
  "userAction": "",
  "dnt": false,
  "heuristicAction": "allow",
  "nextUpdateTime": 1527789195750
}
reastatic.net {
  "userAction": "",
  "dnt": false,
  "heuristicAction": "block",
  "nextUpdateTime": 0
}
s1.rca.reastatic.net {
  "userAction": "",
  "dnt": false,
  "heuristicAction": "allow",
  "nextUpdateTime": 1527702634356
}
s1.rea.reastatic.net {
  "userAction": "",
  "dnt": false,
  "heuristicAction": "block",
  "nextUpdateTime": 1527707862247
}
i4.au.reastatic.net {
  "userAction": "",
  "dnt": false,
  "heuristicAction": "",
  "nextUpdateTime": 1527704075200
}
i1.au.reastatic.net {
  "userAction": "",
  "dnt": false,
  "heuristicAction": "",
  "nextUpdateTime": 1527529402897
}
i3.au.reastatic.net {
  "userAction": "",
  "dnt": false,
  "heuristicAction": "",
  "nextUpdateTime": 1527634411239
}
i2.au.reastatic.net {
  "userAction": "",
  "dnt": false,
  "heuristicAction": "",
  "nextUpdateTime": 1527583141786
}
s1.rui.au.reastatic.net {
  "userAction": "",
  "dnt": false,
  "heuristicAction": "",
  "nextUpdateTime": 1527284548407
}
s2.rea.reastatic.net {
  "userAction": "",
  "dnt": false,
  "heuristicAction": "",
  "nextUpdateTime": 1527770598807
}
**** SNITCH_MAP for reastatic
reastatic.net [
  "property.com.au",
  "realcommercial.com.au",
  "realestate.com.au"
]

@ghostwords
Copy link
Member Author

DNT header test fixed in #2047.

Copy link
Contributor

@bcyphers bcyphers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good too. I noticed reamedia.com.au pop up as a potential tracker on realestate.com.au, but it doesn't look like that domain breaks anything.

@bcyphers bcyphers merged commit 52ce0be into master Jun 21, 2018
@ghostwords ghostwords deleted the add-realestate.com.au-to-mdfp branch June 26, 2018 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MDFP Multi-domain first parties: lists of domains that should be treated as related to each other
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants