Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include cookie duration in tracking heuristic #1545

Open
cowlicks opened this issue Aug 2, 2017 · 6 comments · May be fixed by #2420
Open

Include cookie duration in tracking heuristic #1545

cowlicks opened this issue Aug 2, 2017 · 6 comments · May be fixed by #2420
Labels
enhancement heuristic Badger's core learning-what-to-block functionality login cookies A sub-category of "broken site" issues; might be common enough for us to try to work around entirely yellowlist Domains on this list are allowed but with restrictions: no referrer headers or cookies/localStorage

Comments

@cowlicks
Copy link
Contributor

cowlicks commented Aug 2, 2017

Once this is done, we should remove weatherzone.com.au from the CBL (#1543).

We should also revisit cookies set by things on the CBL to see what their duration is. And what this would fix.

@ghostwords ghostwords added enhancement heuristic Badger's core learning-what-to-block functionality yellowlist Domains on this list are allowed but with restrictions: no referrer headers or cookies/localStorage labels Aug 2, 2017
@ghostwords
Copy link
Member

ghostwords commented Aug 2, 2017

Yep, we should probably account for short-term cookies and maybe also session cookies (#1539 (comment)).

Removing domains from the yellowlist is dicey as long as pre-2017.7.24 releases are still around (#1474 (comment)).

@ghostwords ghostwords changed the title Inculde cookie duration in tracking heuristic. Include cookie duration in tracking heuristic Aug 2, 2017
@cowlicks
Copy link
Contributor Author

cowlicks commented Aug 2, 2017

Since we've mistakenly tied privacy badger versions to cookieblock list behavior, now would be a good time to fix any problems with it. We can make new versions pull from a new URL. And we won't have to worry about breaking old versions.

@ghostwords
Copy link
Member

ghostwords commented Sep 14, 2017

Ignoring session cookies seems like the right thing to do given that session cookies are meant to expire at the end of the browsing session (although apparently browsers preserve session cookies when you set your browser to continue where you left off), which seems to make session cookies much less effective for tracking versus cookies with (far-future) expiration dates.

I think it's worth visiting a bunch of sites (from error reports?) and logging what Badger learned to block because of session cookies alone. If it's all non-tracking domains, let's do it.

@bcyphers
Copy link
Contributor

bcyphers commented May 3, 2018

What's the status on this issue? It looks like we've manually fixed a lot of session cookie-related issues.

@ghostwords
Copy link
Member

It's in the should-probably-happen-but-comes-with-hard-to-understand-implications-and-so-we've-been-collecting-evidence-and-making-one-off-fixes phase. It seems pretty important to look into further, hence it's one of our numerous high priority issues.

@bcyphers
Copy link
Contributor

Now that the big badger-sett scanner is up and running, we can try to get a sense of what most trackers use for expiration times etc. Note to self to do a scan that saves cookie lifetimes.

@ghostwords ghostwords linked a pull request Jul 11, 2019 that will close this issue
4 tasks
ghostwords added a commit that referenced this issue Mar 31, 2020
Short-lived (30 mins) "bot management" cookie.
Related to #1545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement heuristic Badger's core learning-what-to-block functionality login cookies A sub-category of "broken site" issues; might be common enough for us to try to work around entirely yellowlist Domains on this list are allowed but with restrictions: no referrer headers or cookies/localStorage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants