Skip to content

Remote Code Execution (RCE) via archive extraction, password prompt, or video upload

Critical
EDM115 published GHSA-34cg-7f8c-fm5h Dec 2, 2024

Package

docker edm115/unzip-bot (Docker)

Affected versions

< 7.0.3a

Patched versions

7.0.3a

Description

Impact

Type of vulnerability : Remote Code Execution (RCE)
Who is impacted : Any user interacting with archive extraction, password prompts, or video uploads in the affected versions.

Users could exploit unsanitized inputs to inject malicious commands that are executed through subprocess.Popen with shell=True. This vulnerability allows arbitrary command execution, potentially compromising the system.

Examples

How could this vulnerability be exploited ?

  1. Exploitation via malformed archive name :
    An user could craft an archive with a maliciously formatted name. For instance :

    File"; rm -fr / --no-preserve-root; ".zip

    When extracted (or even tested before extraction), this triggers command execution :

    7z t -p"test" "/app/Downloaded/123/File"; rm -fr / --no-preserve-root; ".zip" -y

  2. Exploitation via malformed password input :
    An user could provide a malicious password string during the bot's password prompt. For example :

    password"; rm -fr / --no-preserve-root;"

    This would execute the injected command :

    7z x -o"/app/Downloaded/123/extracted" -p"password"; rm -fr / --no-preserve-root;"" "/app/Downloaded/123/file.7z" -y

  3. Exploitation via malformed video name :
    A malicious archive could contain a video file with a specially crafted name. For example :

    video"; rm -fr / --no-preserve-root;".mp4

    This would result in command execution during thumbnail generation or before, when retrieving the video duration :

    ffprobe -v error -show_entries format=duration -of default=noprint_wrappers=1:nokey=1 "/app/Downloaded/123/extracted/video"; rm -fr / --no-preserve-root;".mp4"

Patches

Is the issue resolved ? What versions contain the fix ?
The vulnerability was addressed in multiple updates. The final and complete fix was implemented on 1st December 2024.

Patch timeline :

  • 14th February 2022 (14268d0) : The bug is present since the first version of the bot.
  • 16th August 2022 (ca8382a) : Partial fix addressing spaces in passwords; RCE persisted.
  • 15th May 2024 (0aebff1) : Addressed issues with spaces in paths; RCE persisted.
  • 1st December 2024 (2c5aba2) : Comprehensive fix using shlex.quote() to sanitize inputs.
  • 1st December 2024 (5213b69) : Final working version of the fix.

Workarounds

Users of the main bot have no issues since this fix was deployed.

Temporary mitigation steps for fork owners :
They need to upgrade either by :

  • Deploying the v7 branch (on Heroku for instance)
  • Pulling the code on their bot (by running the commands /exec git pull && git switch v7 and /restart)
  • By pulling the 7.0.3a tag (if they use a local Docker instance)

References

For more details, refer to :

Severity

Critical

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v4 base metrics

Exploitability Metrics
Attack Vector Network
Attack Complexity Low
Attack Requirements None
Privileges Required None
User interaction None
Vulnerable System Impact Metrics
Confidentiality High
Integrity High
Availability High
Subsequent System Impact Metrics
Confidentiality High
Integrity High
Availability High

CVSS v4 base metrics

Exploitability Metrics
Attack Vector: This metric reflects the context by which vulnerability exploitation is possible. This metric value (and consequently the resulting severity) will be larger the more remote (logically, and physically) an attacker can be in order to exploit the vulnerable system. The assumption is that the number of potential attackers for a vulnerability that could be exploited from across a network is larger than the number of potential attackers that could exploit a vulnerability requiring physical access to a device, and therefore warrants a greater severity.
Attack Complexity: This metric captures measurable actions that must be taken by the attacker to actively evade or circumvent existing built-in security-enhancing conditions in order to obtain a working exploit. These are conditions whose primary purpose is to increase security and/or increase exploit engineering complexity. A vulnerability exploitable without a target-specific variable has a lower complexity than a vulnerability that would require non-trivial customization. This metric is meant to capture security mechanisms utilized by the vulnerable system.
Attack Requirements: This metric captures the prerequisite deployment and execution conditions or variables of the vulnerable system that enable the attack. These differ from security-enhancing techniques/technologies (ref Attack Complexity) as the primary purpose of these conditions is not to explicitly mitigate attacks, but rather, emerge naturally as a consequence of the deployment and execution of the vulnerable system.
Privileges Required: This metric describes the level of privileges an attacker must possess prior to successfully exploiting the vulnerability. The method by which the attacker obtains privileged credentials prior to the attack (e.g., free trial accounts), is outside the scope of this metric. Generally, self-service provisioned accounts do not constitute a privilege requirement if the attacker can grant themselves privileges as part of the attack.
User interaction: This metric captures the requirement for a human user, other than the attacker, to participate in the successful compromise of the vulnerable system. This metric determines whether the vulnerability can be exploited solely at the will of the attacker, or whether a separate user (or user-initiated process) must participate in some manner.
Vulnerable System Impact Metrics
Confidentiality: This metric measures the impact to the confidentiality of the information managed by the VULNERABLE SYSTEM due to a successfully exploited vulnerability. Confidentiality refers to limiting information access and disclosure to only authorized users, as well as preventing access by, or disclosure to, unauthorized ones.
Integrity: This metric measures the impact to integrity of a successfully exploited vulnerability. Integrity refers to the trustworthiness and veracity of information. Integrity of the VULNERABLE SYSTEM is impacted when an attacker makes unauthorized modification of system data. Integrity is also impacted when a system user can repudiate critical actions taken in the context of the system (e.g. due to insufficient logging).
Availability: This metric measures the impact to the availability of the VULNERABLE SYSTEM resulting from a successfully exploited vulnerability. While the Confidentiality and Integrity impact metrics apply to the loss of confidentiality or integrity of data (e.g., information, files) used by the system, this metric refers to the loss of availability of the impacted system itself, such as a networked service (e.g., web, database, email). Since availability refers to the accessibility of information resources, attacks that consume network bandwidth, processor cycles, or disk space all impact the availability of a system.
Subsequent System Impact Metrics
Confidentiality: This metric measures the impact to the confidentiality of the information managed by the SUBSEQUENT SYSTEM due to a successfully exploited vulnerability. Confidentiality refers to limiting information access and disclosure to only authorized users, as well as preventing access by, or disclosure to, unauthorized ones.
Integrity: This metric measures the impact to integrity of a successfully exploited vulnerability. Integrity refers to the trustworthiness and veracity of information. Integrity of the SUBSEQUENT SYSTEM is impacted when an attacker makes unauthorized modification of system data. Integrity is also impacted when a system user can repudiate critical actions taken in the context of the system (e.g. due to insufficient logging).
Availability: This metric measures the impact to the availability of the SUBSEQUENT SYSTEM resulting from a successfully exploited vulnerability. While the Confidentiality and Integrity impact metrics apply to the loss of confidentiality or integrity of data (e.g., information, files) used by the system, this metric refers to the loss of availability of the impacted system itself, such as a networked service (e.g., web, database, email). Since availability refers to the accessibility of information resources, attacks that consume network bandwidth, processor cycles, or disk space all impact the availability of a system.
CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:H/VI:H/VA:H/SC:H/SI:H/SA:H

CVE ID

CVE-2024-53992

Weaknesses

Credits