Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional UI update: Page appears not to refresh when selecting a date window that encompasses the same overall time period. #310

Open
Ben-EJ opened this issue Aug 16, 2024 · 0 comments

Comments

@Ben-EJ
Copy link
Collaborator

Ben-EJ commented Aug 16, 2024

Noticed an issue right before the end of the day with my code in regard to the forecast window code. Sometimes doesn't send any requests at all for example when changing from 4 to 5, but this is very inconsistent for me, sometimes it works, sometimes it doesn't, this only seems to be an issue on the summary page, however. It works great on the single city page.

Steps to reproduce:

2024-08-19.15-32-49.mp4

Expected behaviour:

  • If we select a forecast base window that we don't have a time available for then ideally there should be no requests fired.
  • If we select forecast window of 5, then we should still be able to select smaller ranges.

Actual Behaviour:

  • Even if we only have a base time of 1 available. We can still click 2-3-4 and 5 and have them fire requests.

AC:

  • Only fetch past data within the forecast window
    Check to see if this happens for you. (Might just be a me issue)
    If it is an issue for you, fix bug

On a hard refresh, user is unable to click lower forecast window times besides 1.
Note that this does not happen for dates that are able to fully encompass a 5-day dataset. For example, if we try on the 14/08/2024 we will not see this. Plus, the forecast time range also updates as expected.

@Ben-EJ Ben-EJ changed the title Not sending requests BUG: Not sending requests Aug 16, 2024
@rstrange-scottlogic rstrange-scottlogic changed the title BUG: Not sending requests Additional UI update: Page appears not to refresh when selecting a date window that encompasses the same overall time period. Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants