Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODOs and priorities after 17/7 call #24

Open
5 of 11 tasks
elisaliv opened this issue Jul 17, 2023 · 3 comments
Open
5 of 11 tasks

TODOs and priorities after 17/7 call #24

elisaliv opened this issue Jul 17, 2023 · 3 comments

Comments

@elisaliv
Copy link
Collaborator

elisaliv commented Jul 17, 2023

  • [P1] Select a bounding box from the map, not just countries
  • [P2] Select aggregated countries, e.g. EU --> ask James about GIS libraries or datasets that might help
  • [P1] If we keep using Natural Earth Data, we should make it more flexible. Users should be able to select either countries including their oversea territories, or map units. We can take inspiration from the Wildfire Emission Explorer, as it was pretty flexible and had all they needed
  • [P3] Change Folium map projection to account for surface area
  • [P1] Unit conversion for GHG fluxes: we are interested in the yearly total, not average
  • [P2] Unit conversion for GHG: multiply flux per unit area to each country area
  • [P4] Calculate pixel fraction for GHG data vs. country polygon
  • [P4] Make it flexible to calculate or get the confidence interval for the GHG time series plot
  • [P1] Flexible selection for GHG flux variables (e.g. vegetation is actually more important than fossile fuels)
  • [P4] Think about combining data from different datasets
  • [P3?] Caching of data in Streamlit application

[P1]: definitely must do
[P2]: slightly less important than P1, but still a must-do
[P3]: nice to have, smaller detail
[P4]: we shouldn't aim to do it, but just keep it in mind and document how it should be done

@elisaliv elisaliv changed the title Feedback after 17/7 call TODOs and priorities after 17/7 call Jul 17, 2023
@elisaliv
Copy link
Collaborator Author

elisaliv commented Jul 22, 2023

Previous TODOs we had already started working on:

  • GHG variables and units mapping: see also related TODOs above (and notes from 17/7 call, pasted below). We are only interested in flux variables and mostly in some of them (e.g. a posteriori is more important than a priori)
  • Allow users to select data variables from Streamlit app
  • Plotting API modularization

image

@elisaliv elisaliv pinned this issue Jul 22, 2023
@elisaliv
Copy link
Collaborator Author

elisaliv commented Aug 6, 2023

  • Remove flux_foss as default variable in GHG plot. Let users choose flux type from UI
  • Test GHG unit conversion (also when multiplied by area)
  • Is plotting API modularization really high-priority? Is it worth finishing or is there still a lot missing?
  • Write good documentation on main, leave unfinished work on other branches
  • For EU shapefile / countries aggregation, check out Wildfire Explorer
  • Let users choose between a couple Natural Earth Data shapefile datasets (e.g. with or without oversea territories)?
  • File caching with SQLite

@elisaliv
Copy link
Collaborator Author

elisaliv commented Aug 12, 2023

@luigibrancati luigibrancati unpinned this issue Aug 21, 2023
@luigibrancati luigibrancati pinned this issue Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant