-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How should mappings be handled? #641
Comments
I very much agree and support the removal of mappings from ontologies. And yes, this will cause dbXrefs to be lost from OLS. |
In implementing this we need to take into consideration different ontology editors will have different timescales and approaches to implementing SSSOM. Some may choose to role out SSSOM in 1 go, or in iterations, or (GASP!) not at all. Thus, we are going to have to live with a mixture of ontologies using both dbXref and SSSOM, or only dbXrefs or only SSSOM for some time. I think also for a specific term in a specific ontology it will prudent to assume a mixture of SSSOM and dbXref mappings may be used. Taking this mixture of use into consideration, I think a sensible strategy will be to give preference to SSSOM where a SSSOM mapping exists for a given ontology from OLS should clearly distinguish between SSSOM mappings and other mappings such as dbXref, exactMatch etc defined in the ontology. As an example, lets consider Thoughts @haideriqbal @jamesamcl @matentzn @rombaum @okoepler? |
I would love a clear separation! However, SSSOM is not SSSOM, you can basically provide a valid SSSOM mapping which is in essence just a skos:exactMatch statement with a hazy "semapv:UndefinedMatching" justification. Just putting this out there. My overall preference would be this:
The long term ideal strategy would be to
Now I know this is all a bit much to stem, but anything that rolls the process towards this will be a great victory. |
I think the general consensus in the SSSOM community is that mappings should be moved out of ontologies (hasDbXref) and into external SSSOM files, because (1) it would allow mappings to be updated without updating the ontology, (2) SSSOM has richer semantics than the mapping annotations currently used in ontologies, and (3) mappings are subjective and there is not always one "correct" mapping for a term. @matentzn please correct me if I am wrong about any of this.
If this happens, OLS will start to lose a lot of mapping links between terms which are extremely important for users to navigate between ontologies. I think there are two possibilities for fixing this:
OLS integration with OXO. We had this in OLS3. However mappings were only shown "on demand" when you clicked on the mappings tab as it had to query the OXO API each time, rather than being included in results from the OLS API which I think ideally they should be.
OLS loading SSSOM files. We could add a
mappings
section to the OLS config next toontologies
and load them as part of the OLS "linker" stage. Then they would be materialised in the OLS database.Just throwing some ideas out there and very interested to hear what you think @henrietteharmse
The text was updated successfully, but these errors were encountered: