Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete submission button to Submission details page #241

Open
1 task done
twhetzel opened this issue Apr 7, 2020 · 7 comments
Open
1 task done

Add delete submission button to Submission details page #241

twhetzel opened this issue Apr 7, 2020 · 7 comments
Assignees
Labels

Comments

@twhetzel
Copy link
Collaborator

twhetzel commented Apr 7, 2020

As a curator or user, there may be cases where I need to delete a submission, e.g. created a submission for the wrong publication or need to create a new submisson for the publication linked to the correct Globus account.

  • Add a button on the Submission details page to delete the submission
@twhetzel twhetzel added this to the MVP milestone Apr 7, 2020
@twhetzel twhetzel self-assigned this Apr 7, 2020
@tudorgroza
Copy link
Collaborator

The DELETE endpoint should be there - but let me know if you encounter issues.

@twhetzel
Copy link
Collaborator Author

twhetzel commented Jun 9, 2020

Initial implementation in branch: iss241_add_delete_submission

  • Confirm submissionStatus labels to show this button enabled/disabled with science team
    Blocked until the spec is finalized

@JalMacArthur
Copy link

Laura, Jackie and Jon discussed on 9th June. This is cases where the data is completely incorrect and submission is created in error. For example SS files uploaded for wrong publication i.e. links between publication/GCST/SS file are incorrect and couldn't be corrected by editing metadata.

This option should only be available to curators, not external users. If external users want to make this change they need to contact curators.

We need to be careful as once accession IDs are released they should be stable. Until they are released they can be deleted (by a GWAS Catalog team member).

@twhetzel
Copy link
Collaborator Author

twhetzel commented Jun 9, 2020

@JalMacArthur - ok, so this should only be available for curators. Did you decide what submission status values this button should be enabled for?

@twhetzel
Copy link
Collaborator Author

twhetzel commented Jun 9, 2020

  • update so that this button is only available for users in the Curator domain
  • decide what submission status labels the button should be enabled for

@JalMacArthur
Copy link

This functionality isn't blocking anything, compared to other work e.g. adding reported traits, so it was decided to put on hold until we can discuss in more detail. We need to think about this alongside the need to maintain stable access IDs and the functionality for curators to edit submitted data on bulk.

@twhetzel
Copy link
Collaborator Author

Ok, I'll move this to the "Icebox" category in Zenhub

@twhetzel twhetzel removed this from the MVP milestone Jun 12, 2020
@twhetzel twhetzel added enhancement New feature or request Spec Missing labels Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants