Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAMxx: allow TimeStamp update with fractional value of seconds #6906

Open
bartgol opened this issue Jan 16, 2025 · 0 comments
Open

EAMxx: allow TimeStamp update with fractional value of seconds #6906

bartgol opened this issue Jan 16, 2025 · 0 comments
Assignees
Labels
EAMxx PRs focused on capabilities for EAMxx

Comments

@bartgol
Copy link
Contributor

bartgol commented Jan 16, 2025

While an atm step will always land on an integer second, subcycling of atm process can cause the timestamp to be fractional. Hence, we need to be able to update with fractional seconds, keeping track of the fractional part and reset the tally to 0 whenever we're "close" to integer seconds, to avoid carrying around roundoffs.

Branch bartgol/eamxx/enhance-timestamp-update contains some initial work, but the TimeStamp is not completely self-consistent. E.g., seconds_from does not account for the fractional part. To ensure the class is self consistent, we should remove that method. Since it's basically only used in the TimeInterpolation class, which is destined to be removed in favor of DataInterpolation, we can put this issue on hold until the removal of that class.

@bartgol bartgol added the EAMxx PRs focused on capabilities for EAMxx label Jan 16, 2025
@bartgol bartgol self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EAMxx PRs focused on capabilities for EAMxx
Projects
None yet
Development

No branches or pull requests

1 participant