Fix memory leak in foxglove panels from improper usage of states #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achim-k
changed the title
|
@achim-k Thank you for your contribution. We'll review this in a future club meeting and also check our other panels for this memory leak. |
nathanaelren
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory leak in your sensor status panel (
@duke-robotics/sensors-status-panel). The main change is to removestatefrom the dependency array which would cause theuseEffecthook to be executed every time state changes, causing a memory leakNote: It's likely that there are more of such memory leaks in other panels, I haven't checked these.